You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Eric Evans (Created) (JIRA)" <ji...@apache.org> on 2011/10/03 23:35:33 UTC
[jira] [Created] (CASSANDRA-3299) clientutil depends on FBUtilities
(bad)
clientutil depends on FBUtilities (bad)
---------------------------------------
Key: CASSANDRA-3299
URL: https://issues.apache.org/jira/browse/CASSANDRA-3299
Project: Cassandra
Issue Type: Bug
Components: API, Drivers
Affects Versions: 1.0.0
Reporter: Eric Evans
Assignee: Eric Evans
Fix For: 1.0.1
Attachments: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
clientutils' (indirect )dependency on FBUtilities (needed for tests) would result in huge numbers of classes being pulled in transitively.
The attached patch moves the {{bytesToHex}} and {{hexToBytes}} methods into a new class ({{o.a.c.utils.Hex}}), which has no external dependencies.
This should be pretty safe, but I've marked it fixfor-1.0.1 since we're so close to release, and because the JDBC driver can embed a snapshot jar in the meantime.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3299) clientutil depends on
FBUtilities (bad)
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122995#comment-13122995 ]
Jonathan Ellis commented on CASSANDRA-3299:
-------------------------------------------
True enough. Not a big deal either way, let's go with what you have.
> clientutil depends on FBUtilities (bad)
> ---------------------------------------
>
> Key: CASSANDRA-3299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3299
> Project: Cassandra
> Issue Type: Bug
> Components: API, Drivers
> Affects Versions: 1.0.0
> Reporter: Eric Evans
> Assignee: Eric Evans
> Labels: cql
> Fix For: 1.0.1
>
> Attachments: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
>
>
> clientutils' (indirect )dependency on FBUtilities (needed for tests) would result in huge numbers of classes being pulled in transitively.
> The attached patch moves the {{bytesToHex}} and {{hexToBytes}} methods into a new class ({{o.a.c.utils.Hex}}), which has no external dependencies.
> This should be pretty safe, but I've marked it fixfor-1.0.1 since we're so close to release, and because the JDBC driver can embed a snapshot jar in the meantime.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3299) clientutil depends on
FBUtilities (bad)
Posted by "Eric Evans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124178#comment-13124178 ]
Eric Evans commented on CASSANDRA-3299:
---------------------------------------
you're right; my bad, committed to cassandra-1.0 as well
> clientutil depends on FBUtilities (bad)
> ---------------------------------------
>
> Key: CASSANDRA-3299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3299
> Project: Cassandra
> Issue Type: Bug
> Components: API, Drivers
> Affects Versions: 1.0.0
> Reporter: Eric Evans
> Assignee: Eric Evans
> Labels: cql
> Fix For: 1.0.1
>
> Attachments: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
>
>
> clientutils' (indirect )dependency on FBUtilities (needed for tests) would result in huge numbers of classes being pulled in transitively.
> The attached patch moves the {{bytesToHex}} and {{hexToBytes}} methods into a new class ({{o.a.c.utils.Hex}}), which has no external dependencies.
> This should be pretty safe, but I've marked it fixfor-1.0.1 since we're so close to release, and because the JDBC driver can embed a snapshot jar in the meantime.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3299) clientutil depends on
FBUtilities (bad)
Posted by "Eric Evans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119758#comment-13119758 ]
Eric Evans commented on CASSANDRA-3299:
---------------------------------------
I'm OK with that, but are those names going to be too generic if someone decides to do a static import?
> clientutil depends on FBUtilities (bad)
> ---------------------------------------
>
> Key: CASSANDRA-3299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3299
> Project: Cassandra
> Issue Type: Bug
> Components: API, Drivers
> Affects Versions: 1.0.0
> Reporter: Eric Evans
> Assignee: Eric Evans
> Labels: cql
> Fix For: 1.0.1
>
> Attachments: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
>
>
> clientutils' (indirect )dependency on FBUtilities (needed for tests) would result in huge numbers of classes being pulled in transitively.
> The attached patch moves the {{bytesToHex}} and {{hexToBytes}} methods into a new class ({{o.a.c.utils.Hex}}), which has no external dependencies.
> This should be pretty safe, but I've marked it fixfor-1.0.1 since we're so close to release, and because the JDBC driver can embed a snapshot jar in the meantime.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3299) clientutil depends on
FBUtilities (bad)
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124285#comment-13124285 ]
Hudson commented on CASSANDRA-3299:
-----------------------------------
Integrated in Cassandra #1150 (See [https://builds.apache.org/job/Cassandra/1150/])
move FBUtils methods for bytes<->hex to separate class
Patch by eevans; reviewed by jbellis for CASSANDRA-3299
eevans : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1181018
Files :
* /cassandra/trunk/build.xml
* /cassandra/trunk/drivers/java/test/org/apache/cassandra/cql/JdbcDriverTest.java
* /cassandra/trunk/drivers/java/test/org/apache/cassandra/cql/jdbc/PreparedStatementTest.java
* /cassandra/trunk/examples/simple_authentication/src/org/apache/cassandra/auth/SimpleAuthenticator.java
* /cassandra/trunk/src/java/org/apache/cassandra/auth/Resources.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/marshal/BytesType.java
* /cassandra/trunk/src/java/org/apache/cassandra/dht/AbstractByteOrderedPartitioner.java
* /cassandra/trunk/src/java/org/apache/cassandra/dht/BytesToken.java
* /cassandra/trunk/src/java/org/apache/cassandra/hadoop/ConfigHelper.java
* /cassandra/trunk/src/java/org/apache/cassandra/utils/ByteBufferUtil.java
* /cassandra/trunk/src/java/org/apache/cassandra/utils/FBUtilities.java
* /cassandra/trunk/src/java/org/apache/cassandra/utils/Hex.java
* /cassandra/trunk/src/java/org/apache/cassandra/utils/MerkleTree.java
* /cassandra/trunk/test/unit/org/apache/cassandra/db/marshal/RoundTripTest.java
* /cassandra/trunk/test/unit/org/apache/cassandra/utils/FBUtilitiesTest.java
* /cassandra/trunk/test/unit/org/apache/cassandra/utils/HexTest.java
* /cassandra/trunk/test/unit/org/apache/cassandra/utils/MerkleTreeTest.java
> clientutil depends on FBUtilities (bad)
> ---------------------------------------
>
> Key: CASSANDRA-3299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3299
> Project: Cassandra
> Issue Type: Bug
> Components: API, Drivers
> Affects Versions: 1.0.0
> Reporter: Eric Evans
> Assignee: Eric Evans
> Labels: cql
> Fix For: 1.0.1
>
> Attachments: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
>
>
> clientutils' (indirect )dependency on FBUtilities (needed for tests) would result in huge numbers of classes being pulled in transitively.
> The attached patch moves the {{bytesToHex}} and {{hexToBytes}} methods into a new class ({{o.a.c.utils.Hex}}), which has no external dependencies.
> This should be pretty safe, but I've marked it fixfor-1.0.1 since we're so close to release, and because the JDBC driver can embed a snapshot jar in the meantime.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3299) clientutil depends on
FBUtilities (bad)
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119665#comment-13119665 ]
Jonathan Ellis commented on CASSANDRA-3299:
-------------------------------------------
Nit: can we just name the methods Hex.toBytes and Hex.toString?
+1 otherwise
> clientutil depends on FBUtilities (bad)
> ---------------------------------------
>
> Key: CASSANDRA-3299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3299
> Project: Cassandra
> Issue Type: Bug
> Components: API, Drivers
> Affects Versions: 1.0.0
> Reporter: Eric Evans
> Assignee: Eric Evans
> Labels: cql
> Fix For: 1.0.1
>
> Attachments: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
>
>
> clientutils' (indirect )dependency on FBUtilities (needed for tests) would result in huge numbers of classes being pulled in transitively.
> The attached patch moves the {{bytesToHex}} and {{hexToBytes}} methods into a new class ({{o.a.c.utils.Hex}}), which has no external dependencies.
> This should be pretty safe, but I've marked it fixfor-1.0.1 since we're so close to release, and because the JDBC driver can embed a snapshot jar in the meantime.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3299) clientutil depends on FBUtilities
(bad)
Posted by "Eric Evans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-3299:
----------------------------------
Attachment: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
> clientutil depends on FBUtilities (bad)
> ---------------------------------------
>
> Key: CASSANDRA-3299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3299
> Project: Cassandra
> Issue Type: Bug
> Components: API, Drivers
> Affects Versions: 1.0.0
> Reporter: Eric Evans
> Assignee: Eric Evans
> Labels: cql
> Fix For: 1.0.1
>
> Attachments: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
>
>
> clientutils' (indirect )dependency on FBUtilities (needed for tests) would result in huge numbers of classes being pulled in transitively.
> The attached patch moves the {{bytesToHex}} and {{hexToBytes}} methods into a new class ({{o.a.c.utils.Hex}}), which has no external dependencies.
> This should be pretty safe, but I've marked it fixfor-1.0.1 since we're so close to release, and because the JDBC driver can embed a snapshot jar in the meantime.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3299) clientutil depends on
FBUtilities (bad)
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124168#comment-13124168 ]
Jonathan Ellis commented on CASSANDRA-3299:
-------------------------------------------
I saw this committed to trunk -- if it's intended for 1.0.1 it should also go in the 1.0 branch
> clientutil depends on FBUtilities (bad)
> ---------------------------------------
>
> Key: CASSANDRA-3299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3299
> Project: Cassandra
> Issue Type: Bug
> Components: API, Drivers
> Affects Versions: 1.0.0
> Reporter: Eric Evans
> Assignee: Eric Evans
> Labels: cql
> Fix For: 1.0.1
>
> Attachments: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
>
>
> clientutils' (indirect )dependency on FBUtilities (needed for tests) would result in huge numbers of classes being pulled in transitively.
> The attached patch moves the {{bytesToHex}} and {{hexToBytes}} methods into a new class ({{o.a.c.utils.Hex}}), which has no external dependencies.
> This should be pretty safe, but I've marked it fixfor-1.0.1 since we're so close to release, and because the JDBC driver can embed a snapshot jar in the meantime.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira