You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/07/11 16:54:03 UTC
[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1008: HDDS-1713. ReplicationManager fail to find proper node topology based…
xiaoyuyao commented on a change in pull request #1008: HDDS-1713. ReplicationManager fail to find proper node topology based…
URL: https://github.com/apache/hadoop/pull/1008#discussion_r302646096
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeHeartbeatDispatcher.java
##########
@@ -99,6 +99,9 @@ public SCMDatanodeHeartbeatDispatcher(NodeManager nodeManager,
commands = nodeManager.getCommandQueue(dnID);
} else {
+ // Get the datanode details again from node manager with the topology info
+ // for registered datanodes.
+ datanodeDetails = nodeManager.getNode(datanodeDetails.getIpAddress());
Review comment:
More than one DN instances on the same machine are most likely from test/dev environment such as MiniOzoneCluster. In production, even containers in K8S has dedicate IPs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org