You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/16 20:23:33 UTC

[GitHub] [superset] etr2460 commented on pull request #13606: feat: add warning metadata to tables and metrics

etr2460 commented on pull request #13606:
URL: https://github.com/apache/superset/pull/13606#issuecomment-800578567


   Here are the follow ups i'll make here:
   - Use the yellow caution triangle icon for this to be consistent with other warning icons
   - Update the metrics to pull either warning_markdown or warning_text (to maintain backwards compatibility)
   - Add in a superset-ui PR and dep here which adds the same caution icon for all metric locations
   
   Here's what i'll do in future PRs:
   - DB migration to drop the warning_text from the metric model/table
   - Update superset-ui to not pull the warning_text anymore


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org