You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/12/08 19:55:12 UTC
Review Request 41094: GEODE-642: fix race in OffHeapStorageJUnitTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41094/
-----------------------------------------------------------
Review request for geode and Sai Boorlagadda.
Repository: geode
Description
-------
The problem was caused by the listener not rechecking the system
property every time it was notified of an OutOfOffHeapMemoryException.
Since the code that disconnects the distributed system when
we run out of off-heap memory is async the test would intermittently pass.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java 82cbfeb3eabb7d8256feb9bf372a62b5dc34b276
Diff: https://reviews.apache.org/r/41094/diff/
Testing
-------
OffHeapStorageJUnitTest, OffHeapManagementDUnitTest, and FreeListOffHeapRegionJUnitTest. These are all the tests that use STAY_CONNECTED_ON_OUTOFOFFHEAPMEMORY_PROPERTY.
Thanks,
Darrel Schneider
Re: Review Request 41094: GEODE-642: fix race in
OffHeapStorageJUnitTest
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41094/#review109404
-----------------------------------------------------------
Ship it!
Ship It!
- Sai Boorlagadda
On Dec. 8, 2015, 6:55 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41094/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 6:55 p.m.)
>
>
> Review request for geode and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The problem was caused by the listener not rechecking the system
> property every time it was notified of an OutOfOffHeapMemoryException.
> Since the code that disconnects the distributed system when
> we run out of off-heap memory is async the test would intermittently pass.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java 82cbfeb3eabb7d8256feb9bf372a62b5dc34b276
>
> Diff: https://reviews.apache.org/r/41094/diff/
>
>
> Testing
> -------
>
> OffHeapStorageJUnitTest, OffHeapManagementDUnitTest, and FreeListOffHeapRegionJUnitTest. These are all the tests that use STAY_CONNECTED_ON_OUTOFOFFHEAPMEMORY_PROPERTY.
>
>
> Thanks,
>
> Darrel Schneider
>
>