You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Christoph Kiehl (JIRA)" <ji...@apache.org> on 2007/03/22 12:06:32 UTC

[jira] Created: (JCR-808) Better error message for non-trivial nodetype changes

Better error message for non-trivial nodetype changes
-----------------------------------------------------

                 Key: JCR-808
                 URL: https://issues.apache.org/jira/browse/JCR-808
             Project: Jackrabbit
          Issue Type: Improvement
          Components: core
    Affects Versions: 1.2.3, 1.2.2, 1.2.1, 1.1.1, 1.1, 1.0.1, 1.0
            Reporter: Christoph Kiehl
            Priority: Minor


Currently Jackrabbit only throws a RepositoryException with the message "Not yet implemented". This says almost nothing to newcomers and is very time consuming to debug even if you know what is means. It would be better to use the information already availble through NodeTypeDefDiff to provide a more descriptive error message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-808) Better error message for non-trivial nodetype changes

Posted by "Christoph Kiehl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christoph Kiehl updated JCR-808:
--------------------------------

    Attachment: patch.txt

Revised patch. Also prints out mixin-flag and supertype changes.

> Better error message for non-trivial nodetype changes
> -----------------------------------------------------
>
>                 Key: JCR-808
>                 URL: https://issues.apache.org/jira/browse/JCR-808
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.0, 1.0.1, 1.1, 1.1.1, 1.2.1, 1.2.2, 1.2.3
>            Reporter: Christoph Kiehl
>            Priority: Minor
>         Attachments: patch.txt, patch.txt
>
>
> Currently Jackrabbit only throws a RepositoryException with the message "Not yet implemented". This says almost nothing to newcomers and is very time consuming to debug even if you know what is means. It would be better to use the information already availble through NodeTypeDefDiff to provide a more descriptive error message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-808) Better error message for non-trivial nodetype changes

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-808.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3

Patch applied in revision 526703. Thanks!

> Better error message for non-trivial nodetype changes
> -----------------------------------------------------
>
>                 Key: JCR-808
>                 URL: https://issues.apache.org/jira/browse/JCR-808
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.0, 1.0.1, 1.1, 1.1.1, 1.2.1, 1.2.2, 1.2.3
>            Reporter: Christoph Kiehl
>         Assigned To: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: patch.txt, patch.txt
>
>
> Currently Jackrabbit only throws a RepositoryException with the message "Not yet implemented". This says almost nothing to newcomers and is very time consuming to debug even if you know what is means. It would be better to use the information already availble through NodeTypeDefDiff to provide a more descriptive error message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (JCR-808) Better error message for non-trivial nodetype changes

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting reassigned JCR-808:
---------------------------------

    Assignee: Jukka Zitting

> Better error message for non-trivial nodetype changes
> -----------------------------------------------------
>
>                 Key: JCR-808
>                 URL: https://issues.apache.org/jira/browse/JCR-808
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.0, 1.0.1, 1.1, 1.1.1, 1.2.1, 1.2.2, 1.2.3
>            Reporter: Christoph Kiehl
>         Assigned To: Jukka Zitting
>            Priority: Minor
>         Attachments: patch.txt, patch.txt
>
>
> Currently Jackrabbit only throws a RepositoryException with the message "Not yet implemented". This says almost nothing to newcomers and is very time consuming to debug even if you know what is means. It would be better to use the information already availble through NodeTypeDefDiff to provide a more descriptive error message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-808) Better error message for non-trivial nodetype changes

Posted by "Christoph Kiehl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christoph Kiehl updated JCR-808:
--------------------------------

    Attachment: patch.txt

This patch is just a proposal. Please review. I didn't use StringBuilder for message construction on purpose because I think it's more readable this way and performance shouldn't be an issue here.
I uncommented the code for handling non-trivial changes because it doesn't work right now anyway. We could uncomment it when checkForConflictingContent() is implemented.

> Better error message for non-trivial nodetype changes
> -----------------------------------------------------
>
>                 Key: JCR-808
>                 URL: https://issues.apache.org/jira/browse/JCR-808
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.0, 1.0.1, 1.1, 1.1.1, 1.2.1, 1.2.2, 1.2.3
>            Reporter: Christoph Kiehl
>            Priority: Minor
>         Attachments: patch.txt
>
>
> Currently Jackrabbit only throws a RepositoryException with the message "Not yet implemented". This says almost nothing to newcomers and is very time consuming to debug even if you know what is means. It would be better to use the information already availble through NodeTypeDefDiff to provide a more descriptive error message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.