[GitHub] [superset] solanksh commented on a diff in pull request #21645: feat(charts): allow query mutator to update queries after splitting original sql

[GitBox <gi...@apache.org>]

solanksh commented on code in PR #21645:
URL: https://github.com/apache/superset/pull/21645#discussion_r997237842


##########
superset/models/core.py:
##########
@@ -415,7 +415,11 @@ def get_df(  # pylint: disable=too-many-locals
         mutator: Optional[Callable[[pd.DataFrame], None]] = None,
     ) -> pd.DataFrame:
         sqls = self.db_engine_spec.parse_sql(sql)
+
         engine = self.get_sqla_engine(schema)
+        username = utils.get_username() or username

Review Comment:
   @villebro @baz-bakerhughes I have pushed the changes suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org