You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/14 04:24:38 UTC
[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #230:
feat(version): add maxConsumerTimes to support higher client version
ShannonDing opened a new pull request #230: feat(version): add maxConsumerTimes to support higher client version
URL: https://github.com/apache/rocketmq-client-cpp/pull/230
## What is the purpose of the change
close #229
feat(version): add maxConsumerTimes to support higher client version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #230:
feat(version): add maxConsumerTimes to support higher client version
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #230: feat(version): add maxConsumerTimes to support higher client version
URL: https://github.com/apache/rocketmq-client-cpp/pull/230#issuecomment-573997145
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230?src=pr&el=h1) Report
> Merging [#230](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/555e19d591fa2955eeb62b12d9db8c548b76b412?src=pr&el=desc) will **increase** coverage by `0.45%`.
> The diff coverage is `83.56%`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 51.87% 52.33% +0.45%
==========================================
Files 174 174
Lines 10858 10931 +73
==========================================
+ Hits 5633 5721 +88
+ Misses 5225 5210 -15
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [include/DefaultMQPushConsumer.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230/diff?src=pr&el=tree#diff-aW5jbHVkZS9EZWZhdWx0TVFQdXNoQ29uc3VtZXIuaA==) | `0% <ø> (ø)` | :arrow_up: |
| [src/protocol/CommandHeader.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuaA==) | `79.26% <ø> (+2.43%)` | :arrow_up: |
| [src/consumer/DefaultMQPushConsumer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL0RlZmF1bHRNUVB1c2hDb25zdW1lci5jcHA=) | `6.44% <0%> (-0.1%)` | :arrow_down: |
| [src/consumer/ConsumeMessageConcurrentlyService.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL0NvbnN1bWVNZXNzYWdlQ29uY3VycmVudGx5U2VydmljZS5jcHA=) | `0% <0%> (ø)` | :arrow_up: |
| [src/MQClientAPIImpl.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50QVBJSW1wbC5jcHA=) | `20.28% <100%> (+3.79%)` | :arrow_up: |
| [src/protocol/CommandHeader.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL0NvbW1hbmRIZWFkZXIuY3Bw) | `85.44% <100%> (+2.22%)` | :arrow_up: |
| [test/src/protocol/CommandHeaderTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230/diff?src=pr&el=tree#diff-dGVzdC9zcmMvcHJvdG9jb2wvQ29tbWFuZEhlYWRlclRlc3QuY3Bw) | `100% <100%> (ø)` | :arrow_up: |
| [test/src/MQClientAPIImpTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230/diff?src=pr&el=tree#diff-dGVzdC9zcmMvTVFDbGllbnRBUElJbXBUZXN0LmNwcA==) | `98.37% <100%> (+0.26%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230?src=pr&el=footer). Last update [555e19d...4456300](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/230?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #230:
feat(version): add maxConsumerTimes to support higher client version
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #230: feat(version): add maxConsumerTimes to support higher client version
URL: https://github.com/apache/rocketmq-client-cpp/pull/230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services