You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:55:19 UTC

Review Request 61298: Replaced `include_directories()` for `mesos-protobufs`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61298/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

The `include_directories()` CMake command should never be used as it has
global side effects, and is superfluous when the CMake dependency graph
is used correctly.


Diffs
-----

  src/CMakeLists.txt 98ccaf41bf5e7d14164e1c8b6e49268ac865a52c 


Diff: https://reviews.apache.org/r/61298/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer