You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@apache.org> on 2019/02/06 16:35:21 UTC
Review Request 69907: Fixed variable names in
`Master::_doRegistryGC()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69907/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Greg Mann.
Repository: mesos
Description
-------
Substituted `slave` with `slaveId` to be consistent with the code base.
No functional changes.
Diffs
-----
src/master/master.cpp 4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f
Diff: https://reviews.apache.org/r/69907/diff/1/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 69907: Fixed variable names in
`Master::_doRegistryGC()`.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69907/
-----------------------------------------------------------
(Updated Feb. 15, 2019, 6:02 p.m.)
Review request for mesos, Gastón Kleiman and Greg Mann.
Changes
-------
Addressed gaston's comments. NNFR.
Repository: mesos
Description
-------
Substituted `slave` with `slaveId` to be consistent with the code base.
No functional changes.
Diffs (updated)
-----
src/master/master.cpp 8e23785006b4f4962770d8bba163f977b8b33414
Diff: https://reviews.apache.org/r/69907/diff/2/
Changes: https://reviews.apache.org/r/69907/diff/1-2/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 69907: Fixed variable names in
`Master::_doRegistryGC()`.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69907/#review212848
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Line 1799 (original), 1799 (patched)
<https://reviews.apache.org/r/69907/#comment298733>
Can you fix it here too?
- Gastón Kleiman
On Feb. 6, 2019, 8:35 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69907/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2019, 8:35 a.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Substituted `slave` with `slaveId` to be consistent with the code base.
> No functional changes.
>
>
> Diffs
> -----
>
> src/master/master.cpp 4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f
>
>
> Diff: https://reviews.apache.org/r/69907/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>