You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/09/26 00:54:18 UTC
[GitHub] incubator-brooklyn pull request: be soft not weak (WeakReference -...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/188
be soft not weak (WeakReference -> SoftReference)
use SoftReference when we have a Reference to an object which should be GC'd only when memory gets full
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn be-soft-not-weak
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit 24b11d1d6362e07be583a3935ffd46ed3f777fc2
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-09-25T22:52:37Z
be soft not weak, when we have a Reference to an object which should be GC'd only when memory gets full
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: be soft not weak (WeakReference -...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: be soft not weak (WeakReference -...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/188#issuecomment-56922620
Straightforward change, so merging :frog: We can always add `WeakReference` support back in if it turns out to be required elsewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---