You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/05/12 20:57:03 UTC

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4253: Fixed python function context.publish with properties

jerrypeng commented on a change in pull request #4253: Fixed python function context.publish with properties
URL: https://github.com/apache/pulsar/pull/4253#discussion_r283154288
 
 

 ##########
 File path: pulsar-functions/instance/src/main/python/contextimpl.py
 ##########
 @@ -152,7 +152,7 @@ def callback_wrapper(self, callback, topic, message_id, result, msg):
   def publish(self, topic_name, message, serde_class_name="serde.IdentitySerDe", properties=None, compression_type=None, callback=None):
 
 Review comment:
   @merlimat we can delete this method then

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services