You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/06/24 17:44:04 UTC
[PR] fix(catalog/rest): close SigV4 signing body clone [iceberg-go]
fallintoplace opened a new pull request, #1304:
URL: https://github.com/apache/iceberg-go/pull/1304
Summary
- close the request body clone used to hash SigV4 payloads
- return close errors from the signing path instead of sending a request after cleanup fails
- add regression coverage for both successful close and close-error paths
Why
The REST session transport uses request.GetBody() to hash signed request payloads without consuming the original request body. That cloned reader is owned by the signing path, but it was left open after io.Copy finished. Under repeated signed POST or commit requests, that can leak any resources held by custom body clones.
Testing
- go test ./catalog/rest -run 'TestSigv4(ClosesClonedRequestBody|ReturnsClonedRequestBodyCloseError|ContentSha256Header)' -count=1
- go test ./catalog/rest -count=1
- go test ./catalog/... -count=1
- go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.4 run --timeout=10m ./catalog/rest/...
- git diff --check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(catalog/rest): close SigV4 signing body clone [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1304:
URL: https://github.com/apache/iceberg-go/pull/1304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org