You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/16 12:39:57 UTC

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
-----------------------------------------------------------

(Updated Feb. 16, 2016, 11:39 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
-------

Rebase


Summary (updated)
-----------------

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.


Bugs: MESOS-4618
    https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description (updated)
-------

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.


Diffs (updated)
-----

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing
-------

Before

```
[       OK ] FetcherCacheTest.SimpleEviction (4516 ms)
[----------] 1 test from FetcherCacheTest (4516 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (4527 ms total)
[  PASSED  ] 1 test.
```

After

```
[       OK ] FetcherCacheTest.SimpleEviction (3602 ms)
[----------] 1 test from FetcherCacheTest (3602 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (3612 ms total)
[  PASSED  ] 1 test.
```


Thanks,

haosdent huang


Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/#review119301
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On Feb. 16, 2016, 12:39 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43316/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4618
>     https://issues.apache.org/jira/browse/MESOS-4618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43316/diff/
> 
> 
> Testing
> -------
> 
> Before
> 
> ```
> [       OK ] FetcherCacheTest.SimpleEviction (4516 ms)
> [----------] 1 test from FetcherCacheTest (4516 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (4527 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> After
> 
> ```
> [       OK ] FetcherCacheTest.SimpleEviction (3602 ms)
> [----------] 1 test from FetcherCacheTest (3602 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (3612 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
-----------------------------------------------------------

(Updated Feb. 16, 2016, 5:55 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd Mathiske.


Changes
-------

Rebase


Bugs: MESOS-4618
    https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description
-------

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.


Diffs (updated)
-----

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing (updated)
-------

Before
```
[       OK ] FetcherCacheTest.SimpleEviction (4536 ms)
```

After
```
[       OK ] FetcherCacheTest.SimpleEviction (3635 ms)
```


Thanks,

haosdent huang