[jira] [Commented] (PROTON-145) 256K Messages do not get transfered properly with a 64k pump size

["Rob Godfrey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500326#comment-13500326 ] 

Rob Godfrey commented on PROTON-145:
------------------------------------

Are changes such as this actually necessary to make it work:

-            while(endpoint != null && buffer.remaining() >= _maxFrameSize)
+            while(endpoint != null && buffer.remaining() > _maxFrameSize)

I would think that >= would be correct (you have *exactly* enough space for a frame) ... would be nervous about committing this change if this is required as it would seem to point at a larger issue.


                
> 256K Messages do not get transfered properly with a 64k pump size
> -----------------------------------------------------------------
>
>                 Key: PROTON-145
>                 URL: https://issues.apache.org/jira/browse/PROTON-145
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-j
>            Reporter: Hiram Chirino
>         Attachments: PROTON-145-Fix.patch, PROTON-145-Test.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira