You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "sakshi2894 (GitHub)" <gi...@apache.org> on 2018/08/23 13:31:23 UTC
[GitHub] [incubator-airflow] sakshi2894 opened pull request #3790:
[AIRFLOW-2994] Fix command status check in Qubole Check operator
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-2994\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2994
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
Exception message shouldn't contain Qubole command results if the command fails. This PR fixes a bug which causes this behaviour.
### Tests
- [ ] My PR adds the following unit tests:
`test_execute_assert_query_fail` - Tests that the exception message doesn't contain Qubole command id and results if the command has failed.
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
### Code Quality
- [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
[ Full content available at: https://github.com/apache/incubator-airflow/pull/3790 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-airflow] codecov-io commented on issue #3790:
[AIRFLOW-2994] Fix command status check in Qubole Check operator
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=h1) Report
> Merging [#3790](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-airflow/commit/6afd38d79b2439ca5e3bb349c5d2007ad09aa27f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3790 +/- ##
=========================================
- Coverage 77.41% 77.4% -0.01%
=========================================
Files 203 203
Lines 15810 15810
=========================================
- Hits 12239 12238 -1
- Misses 3571 3572 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models.py](https://codecov.io/gh/apache/incubator-airflow/pull/3790/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMucHk=) | `88.74% <0%> (-0.05%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=footer). Last update [6afd38d...2750e5d](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-airflow/pull/3790 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-airflow] feng-tao commented on issue #3790:
[AIRFLOW-2994] Fix command status check in Qubole Check operator
Posted by "feng-tao (GitHub)" <gi...@apache.org>.
It seems python3 fails. Do you know if it is related?
[ Full content available at: https://github.com/apache/incubator-airflow/pull/3790 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-airflow] msumit commented on issue #3790:
[AIRFLOW-2994] Fix command status check in Qubole Check operator
Posted by "msumit (GitHub)" <gi...@apache.org>.
lgtm
[ Full content available at: https://github.com/apache/incubator-airflow/pull/3790 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-airflow] codecov-io commented on issue #3790:
[AIRFLOW-2994] Fix command status check in Qubole Check operator
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=h1) Report
> Merging [#3790](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-airflow/commit/6afd38d79b2439ca5e3bb349c5d2007ad09aa27f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3790 +/- ##
=========================================
- Coverage 77.41% 77.4% -0.01%
=========================================
Files 203 203
Lines 15810 15810
=========================================
- Hits 12239 12238 -1
- Misses 3571 3572 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models.py](https://codecov.io/gh/apache/incubator-airflow/pull/3790/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMucHk=) | `88.74% <0%> (-0.05%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=footer). Last update [6afd38d...2750e5d](https://codecov.io/gh/apache/incubator-airflow/pull/3790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-airflow/pull/3790 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-airflow] msumit closed pull request #3790:
[AIRFLOW-2994] Fix command status check in Qubole Check operator
Posted by "msumit (GitHub)" <gi...@apache.org>.
[ pull request closed by msumit ]
[ Full content available at: https://github.com/apache/incubator-airflow/pull/3790 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org