[GitHub] [beam] liferoad commented on a diff in pull request #26923: fix output_handler

["liferoad (via GitHub)" <gi...@apache.org>]

liferoad commented on code in PR #26923:
URL: https://github.com/apache/beam/pull/26923#discussion_r1210757830


##########
sdks/python/apache_beam/transforms/util_test.py:
##########
@@ -902,6 +904,19 @@ def test_in_global_window(self):
                       GroupIntoBatchesTest.BATCH_SIZE))
           ]))
 
+  def test_in_global_window_with_text_file(self):
+    with self.assertRaises(NotImplementedError):

Review Comment:
   note this test just confirms the code path with output_handler works but the feature is not implemented for DirectRunner



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org