[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6118: Feature/refetch

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #6118:
URL: https://github.com/apache/trafficcontrol/pull/6118#discussion_r724634848



##########
File path: traffic_ops/traffic_ops_golang/invalidationjobs/invalidationjobs.go
##########
@@ -42,52 +42,40 @@ import (
 	"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
 )
 
+// Deprecated, only to be used with versions below 4.0
 type InvalidationJob struct {
 	api.APIInfoImpl `json:"-"`
 	tc.InvalidationJob
 }
 
-const readQuery = `
-SELECT job.id,
-       keyword,
-       parameters,
-       asset_url,
-       start_time,
-       u.username AS createdBy,
-       ds.xml_id AS dsId
-FROM job
-JOIN tm_user u ON job.job_user = u.id
-JOIN deliveryservice ds  ON job.job_deliveryservice = ds.id
-`
+type InvalidationJobV40 struct {
+	api.APIInfoImpl `json:"-"`
+	tc.InvalidationJobV40
+}

Review comment:
       CRUDer is fine if that's how you wanna do it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org