You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@newton.ch.collab.net> on 2002/10/17 17:38:02 UTC
Re: svn commit: rev 3387 - trunk/subversion/svnadmin trunk/subversion/include trunk/subversion/libsvn_subr trunk/subversion/clients/cmdline trunk/subversion/tests/clients/cmdline/getopt_tests_data
ghudson@tigris.org writes:
> Clean up the colon-in-dates issue, by nuking the -D flag and adding
> "{date}" as a revision specification. This also lets you do things
> like -r "{date}:rev" for date specs.
Whoo-hoo!
> Also, stamp out the nascent convention of using svn_boolean_t to
> report the failure (not success) of an operation. 0-on-success is
> fine, but FALSE-on-success/TRUE-on-failure is just plain confusing.
> Use 0 for success and -1 for failure, like POSIX system calls.
Thanks for that too. If you wanted to add something to HACKING about
it, I wouldn't be averse... (might continue to be subverse, however).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 3387 - trunk/subversion/svnadmin
trunk/subversion/include trunk/subversion/libsvn_subr
trunk/subversion/clients/cmdline
trunk/subversion/tests/clients/cmdline/getopt_tests_data
Posted by Greg Hudson <gh...@MIT.EDU>.
On Thu, 2002-10-17 at 13:38, Karl Fogel wrote:
> Thanks for that too. If you wanted to add something to HACKING about
> it, I wouldn't be averse... (might continue to be subverse, however).
The vast majority of the time, we return an svn_error_t *, so it's not
an issue. I made sure there were no other instances of using
svn_boolean_t for this purpose, at least not in the public interfaces.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org