You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Antonio Petrelli (JIRA)" <ji...@codehaus.org> on 2011/12/14 14:47:02 UTC

[jira] (MASSEMBLY-591) Empty classifier in dependency causes extra dash

Antonio Petrelli created MASSEMBLY-591:
------------------------------------------

             Summary: Empty classifier in dependency causes extra dash
                 Key: MASSEMBLY-591
                 URL: https://jira.codehaus.org/browse/MASSEMBLY-591
             Project: Maven 2.x Assembly Plugin
          Issue Type: Bug
    Affects Versions: 2.2.2
            Reporter: Antonio Petrelli
            Priority: Minor
         Attachments: assemblybug.zip

When having a dependency with an empty classifier element, adding it as a dependency set causes an extra dash to appear in the file name.
For example, when I add a dependency of this type (notice the empty classifier element):

[snip]
    <dependency>
      <groupId>org.apache.tiles</groupId>
      <artifactId>tiles-api</artifactId>
      <version>2.2.2</version>
      <classifier />
    </dependency>
[/snip]

and I put it inside the assembly descriptor:
[snip]
  <dependencySets>
    <dependencySet>
      <outputDirectory>/</outputDirectory>
    </dependencySet>
  </dependencySets>
[/snip]


I see that the tiles-api jar contains an extra dash in its name:
tiles-api-2.2.2-.jar


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MASSEMBLY-591) Empty classifier in dependency causes extra dash

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MASSEMBLY-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=312210#comment-312210 ] 

Dennis Lundberg commented on MASSEMBLY-591:
-------------------------------------------

Yeah, we have like 3000+ unresolved issues in total for Maven, and 150 of those are for the Assembly plugin alone. So unfortunately it can take a while for a patch to be applied. Thanks again for the patch!
                
> Empty classifier in dependency causes extra dash
> ------------------------------------------------
>
>                 Key: MASSEMBLY-591
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-591
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.2
>            Reporter: Antonio Petrelli
>            Assignee: Dennis Lundberg
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: assemblybug.zip, assembly-dash-classifier-patch.diff
>
>
> When having a dependency with an empty classifier element, adding it as a dependency set causes an extra dash to appear in the file name.
> For example, when I add a dependency of this type (notice the empty classifier element):
> [snip]
>     <dependency>
>       <groupId>org.apache.tiles</groupId>
>       <artifactId>tiles-api</artifactId>
>       <version>2.2.2</version>
>       <classifier />
>     </dependency>
> [/snip]
> and I put it inside the assembly descriptor:
> [snip]
>   <dependencySets>
>     <dependencySet>
>       <outputDirectory>/</outputDirectory>
>     </dependencySet>
>   </dependencySets>
> [/snip]
> I see that the tiles-api jar contains an extra dash in its name:
> tiles-api-2.2.2-.jar

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MASSEMBLY-591) Empty classifier in dependency causes extra dash

Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MASSEMBLY-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=312196#comment-312196 ] 

Antonio Petrelli commented on MASSEMBLY-591:
--------------------------------------------

Wow I almost forgot about this bug. 10 months to apply a patch... Anyway thank you.
                
> Empty classifier in dependency causes extra dash
> ------------------------------------------------
>
>                 Key: MASSEMBLY-591
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-591
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.2
>            Reporter: Antonio Petrelli
>            Assignee: Dennis Lundberg
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: assemblybug.zip, assembly-dash-classifier-patch.diff
>
>
> When having a dependency with an empty classifier element, adding it as a dependency set causes an extra dash to appear in the file name.
> For example, when I add a dependency of this type (notice the empty classifier element):
> [snip]
>     <dependency>
>       <groupId>org.apache.tiles</groupId>
>       <artifactId>tiles-api</artifactId>
>       <version>2.2.2</version>
>       <classifier />
>     </dependency>
> [/snip]
> and I put it inside the assembly descriptor:
> [snip]
>   <dependencySets>
>     <dependencySet>
>       <outputDirectory>/</outputDirectory>
>     </dependencySet>
>   </dependencySets>
> [/snip]
> I see that the tiles-api jar contains an extra dash in its name:
> tiles-api-2.2.2-.jar

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MASSEMBLY-591) Empty classifier in dependency causes extra dash

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MASSEMBLY-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MASSEMBLY-591.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4
         Assignee: Dennis Lundberg

Patch applied in r1401695.
Thank you!
                
> Empty classifier in dependency causes extra dash
> ------------------------------------------------
>
>                 Key: MASSEMBLY-591
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-591
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.2
>            Reporter: Antonio Petrelli
>            Assignee: Dennis Lundberg
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: assemblybug.zip, assembly-dash-classifier-patch.diff
>
>
> When having a dependency with an empty classifier element, adding it as a dependency set causes an extra dash to appear in the file name.
> For example, when I add a dependency of this type (notice the empty classifier element):
> [snip]
>     <dependency>
>       <groupId>org.apache.tiles</groupId>
>       <artifactId>tiles-api</artifactId>
>       <version>2.2.2</version>
>       <classifier />
>     </dependency>
> [/snip]
> and I put it inside the assembly descriptor:
> [snip]
>   <dependencySets>
>     <dependencySet>
>       <outputDirectory>/</outputDirectory>
>     </dependencySet>
>   </dependencySets>
> [/snip]
> I see that the tiles-api jar contains an extra dash in its name:
> tiles-api-2.2.2-.jar

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MASSEMBLY-591) Empty classifier in dependency causes extra dash

Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MASSEMBLY-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli updated MASSEMBLY-591:
---------------------------------------

    Attachment: assembly-dash-classifier-patch.diff

Added patch to fix the problem locally to maven-assembly-plugin.
                
> Empty classifier in dependency causes extra dash
> ------------------------------------------------
>
>                 Key: MASSEMBLY-591
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-591
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.2
>            Reporter: Antonio Petrelli
>            Priority: Minor
>         Attachments: assemblybug.zip, assembly-dash-classifier-patch.diff
>
>
> When having a dependency with an empty classifier element, adding it as a dependency set causes an extra dash to appear in the file name.
> For example, when I add a dependency of this type (notice the empty classifier element):
> [snip]
>     <dependency>
>       <groupId>org.apache.tiles</groupId>
>       <artifactId>tiles-api</artifactId>
>       <version>2.2.2</version>
>       <classifier />
>     </dependency>
> [/snip]
> and I put it inside the assembly descriptor:
> [snip]
>   <dependencySets>
>     <dependencySet>
>       <outputDirectory>/</outputDirectory>
>     </dependencySet>
>   </dependencySets>
> [/snip]
> I see that the tiles-api jar contains an extra dash in its name:
> tiles-api-2.2.2-.jar

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MASSEMBLY-591) Empty classifier in dependency causes extra dash

Posted by "Antonio Petrelli (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MASSEMBLY-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285887#comment-285887 ] 

Antonio Petrelli commented on MASSEMBLY-591:
--------------------------------------------

Using Maven 3.0.3 as a dependency for maven-assembly-plugin the bug still exists.
                
> Empty classifier in dependency causes extra dash
> ------------------------------------------------
>
>                 Key: MASSEMBLY-591
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-591
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.2
>            Reporter: Antonio Petrelli
>            Priority: Minor
>         Attachments: assemblybug.zip
>
>
> When having a dependency with an empty classifier element, adding it as a dependency set causes an extra dash to appear in the file name.
> For example, when I add a dependency of this type (notice the empty classifier element):
> [snip]
>     <dependency>
>       <groupId>org.apache.tiles</groupId>
>       <artifactId>tiles-api</artifactId>
>       <version>2.2.2</version>
>       <classifier />
>     </dependency>
> [/snip]
> and I put it inside the assembly descriptor:
> [snip]
>   <dependencySets>
>     <dependencySet>
>       <outputDirectory>/</outputDirectory>
>     </dependencySet>
>   </dependencySets>
> [/snip]
> I see that the tiles-api jar contains an extra dash in its name:
> tiles-api-2.2.2-.jar

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira