[GitHub] [maven] michael-o commented on a diff in pull request #810: [MNG-7556] Clean up notion between user properties and system properties

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #810:
URL: https://github.com/apache/maven/pull/810#discussion_r989731168


##########
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##########
@@ -338,9 +338,9 @@ public void testMVNConfigurationFunkyArguments()
         String revision = System.getProperty( "revision" );
         assertEquals( "8.2.0", revision );
 
-        assertEquals( "bar ", request.getSystemProperties().getProperty( "foo" ) );
-        assertEquals( "bar two", request.getSystemProperties().getProperty( "foo2" ) );
-        assertEquals( "Apache Maven", request.getSystemProperties().getProperty( "label" ) );
+        assertEquals( "bar ", request.getUserProperties().getProperty( "foo" ) );
+        assertEquals( "bar two", request.getUserProperties().getProperty( "foo2" ) );
+        assertEquals( "Apache Maven", request.getUserProperties().getProperty( "label" ) );

Review Comment:
   Yes, correct. This explicitly not subject of this PR. This statement should go away sometime in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org