You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2012/04/26 10:46:12 UTC
[jira] [Created] (WICKET-4518) Wicket example 'forminput' is broken
due to bad url for IOnChangeListener
Martin Grigorov created WICKET-4518:
---------------------------------------
Summary: Wicket example 'forminput' is broken due to bad url for IOnChangeListener
Key: WICKET-4518
URL: https://issues.apache.org/jira/browse/WICKET-4518
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5.6
Reporter: Martin Grigorov
Fix For: 1.5.6
http://localhost:8080/forminput (wicket-examples) doesn't change the locale of the labels when the locale select is changed.
The reason seems to be the produced url: './.?5-1.IOnChangeListener-inputForm-localeSelect'
This is parsed to a Url with one empty segment and thus HomePageMapper doesn't match it and doesn't handle it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4518) Wicket example 'forminput' is broken
due to bad url for IOnChangeListener
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier updated WICKET-4518:
-------------------------------
Attachment: WICKET-4518-alternative.patch
Alternative patch: If resolving a relative url removes a leading dot, it should remove a following empty segment to.
> Wicket example 'forminput' is broken due to bad url for IOnChangeListener
> -------------------------------------------------------------------------
>
> Key: WICKET-4518
> URL: https://issues.apache.org/jira/browse/WICKET-4518
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.6
> Reporter: Martin Grigorov
> Fix For: 1.5.6
>
> Attachments: WICKET-4518-alternative.patch, WICKET-4518.patch
>
>
> http://localhost:8080/forminput (wicket-examples) doesn't change the locale of the labels when the locale select is changed.
> The reason seems to be the produced url: './.?5-1.IOnChangeListener-inputForm-localeSelect'
> This is parsed to a Url with one empty segment and thus HomePageMapper doesn't match it and doesn't handle it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4518) Wicket example 'forminput' is
broken due to bad url for IOnChangeListener
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262484#comment-13262484 ]
Martin Grigorov commented on WICKET-4518:
-----------------------------------------
The problem comes from WICKET-4260.
Form.java, line 527:
Url action = Url.parse(getActionUrl().toString());
#getActionUrl() returns something like : './?1-1.SomeListener' . Before WICKET-4260 it was '?1-1.SomeListener'.
Url.parse()-ing that produces an Url with two segments: [., ], before 4260: [].
> Wicket example 'forminput' is broken due to bad url for IOnChangeListener
> -------------------------------------------------------------------------
>
> Key: WICKET-4518
> URL: https://issues.apache.org/jira/browse/WICKET-4518
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.6
> Reporter: Martin Grigorov
> Fix For: 1.5.6
>
>
> http://localhost:8080/forminput (wicket-examples) doesn't change the locale of the labels when the locale select is changed.
> The reason seems to be the produced url: './.?5-1.IOnChangeListener-inputForm-localeSelect'
> This is parsed to a Url with one empty segment and thus HomePageMapper doesn't match it and doesn't handle it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4518) Wicket example 'forminput' is
broken due to bad url for IOnChangeListener
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier resolved WICKET-4518.
--------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0-RC1
Assignee: Sven Meier
Url allows all kind of strange segments, so I decided to keep "./?foo" allowed. resolveRelative() now takes care to remove any leading "./", ".//" and additionally empty segments too.
> Wicket example 'forminput' is broken due to bad url for IOnChangeListener
> -------------------------------------------------------------------------
>
> Key: WICKET-4518
> URL: https://issues.apache.org/jira/browse/WICKET-4518
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.6
> Reporter: Martin Grigorov
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-RC1
>
> Attachments: WICKET-4518-alternative.patch, WICKET-4518.patch
>
>
> http://localhost:8080/forminput (wicket-examples) doesn't change the locale of the labels when the locale select is changed.
> The reason seems to be the produced url: './.?5-1.IOnChangeListener-inputForm-localeSelect'
> This is parsed to a Url with one empty segment and thus HomePageMapper doesn't match it and doesn't handle it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4518) Wicket example 'forminput' is
broken due to bad url for IOnChangeListener
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262686#comment-13262686 ]
Martin Grigorov commented on WICKET-4518:
-----------------------------------------
Urls like '././././././some/thing/meaningful' should be treated as 'some/thing/meaningful' so I suggest using 'while' instead of 'if'.
Code that manipulates strings has always been one of my nightmares so feel free to improve it as you find better.
> Wicket example 'forminput' is broken due to bad url for IOnChangeListener
> -------------------------------------------------------------------------
>
> Key: WICKET-4518
> URL: https://issues.apache.org/jira/browse/WICKET-4518
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.6
> Reporter: Martin Grigorov
> Fix For: 1.5.6
>
> Attachments: WICKET-4518-alternative.patch, WICKET-4518.patch
>
>
> http://localhost:8080/forminput (wicket-examples) doesn't change the locale of the labels when the locale select is changed.
> The reason seems to be the produced url: './.?5-1.IOnChangeListener-inputForm-localeSelect'
> This is parsed to a Url with one empty segment and thus HomePageMapper doesn't match it and doesn't handle it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4518) Wicket example 'forminput' is broken
due to bad url for IOnChangeListener
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4518:
------------------------------------
Attachment: WICKET-4518.patch
Attaching a suggested patch.
> Wicket example 'forminput' is broken due to bad url for IOnChangeListener
> -------------------------------------------------------------------------
>
> Key: WICKET-4518
> URL: https://issues.apache.org/jira/browse/WICKET-4518
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.6
> Reporter: Martin Grigorov
> Fix For: 1.5.6
>
> Attachments: WICKET-4518.patch
>
>
> http://localhost:8080/forminput (wicket-examples) doesn't change the locale of the labels when the locale select is changed.
> The reason seems to be the produced url: './.?5-1.IOnChangeListener-inputForm-localeSelect'
> This is parsed to a Url with one empty segment and thus HomePageMapper doesn't match it and doesn't handle it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira