You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/04/20 12:49:55 UTC

Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/
-----------------------------------------------------------

Review request for Ambari, Madhuvanthi Radhakrishnan and Sumit Mohanty.


Bugs: AMBARI-20802
    https://issues.apache.org/jira/browse/AMBARI-20802


Repository: ambari


Description
-------

When a minimal Blueprint install was attempted in that issue, some failures occurred during the Blueprint deployment.
After some investigation, we determined that the Blueprints processor was throwing a NullPointerException, due to some configuration types being considered "updated", even though those configuration types are not included in the "desired configuration" for the cluster, since the services associated with those configuration types are not deployed in this current cluster.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java ce36208 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml be79331 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 6cd6d35 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py ad35688 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 7ef5fad 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py f9fb1f5 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 2d7322d 


Diff: https://reviews.apache.org/r/58568/diff/1/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi