You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/05/17 14:07:22 UTC

[GitHub] flink pull request #6033: [FLINK-6909] [types] Add tests for Lombok POJOs

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/6033

    [FLINK-6909] [types] Add tests for Lombok POJOs

    ## What is the purpose of the change
    
    Add tests for POJOs generated with Lombok. We add these tests to notice incompatibilities when updating Java versions or type extraction in the future.
    
    ## Brief change log
    
    - Unit test added
    
    ## Verifying this change
    
    - Unit test added
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): yes
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-6909_2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6033.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6033
    
----
commit 1e1d412bf5f89d0e035f51cb8be9e530760f4621
Author: Timo Walther <tw...@...>
Date:   2018-05-17T13:54:07Z

    [FLINK-6909] [types] Add tests for Lombok POJOs

----


---

[GitHub] flink issue #6033: [FLINK-6909] [types] Add tests for Lombok POJOs

Posted by twalthr <gi...@git.apache.org>.

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/6033
  
    Thank you @zentol. Merging...


---

[GitHub] flink pull request #6033: [FLINK-6909] [types] Add tests for Lombok POJOs

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6033


---