You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Satadru Pan (JIRA)" <ji...@apache.org> on 2012/10/11 21:25:02 UTC
[jira] [Created] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Satadru Pan created HIVE-3570:
---------------------------------
Summary: Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Key: HIVE-3570
URL: https://issues.apache.org/jira/browse/HIVE-3570
Project: Hive
Issue Type: Improvement
Components: Statistics
Affects Versions: 0.9.0
Reporter: Satadru Pan
Priority: Minor
Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3570:
-----------------------------
Status: Open (was: Patch Available)
Comments on phabricator
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489842#comment-13489842 ]
Hudson commented on HIVE-3570:
------------------------------
Integrated in Hive-trunk-h0.21 #1770 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1770/])
HIVE-3570 Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out
counter for GroupBy Optr (Satadru Pan via namit) (Revision 1404933)
Result = FAILURE
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1404933
Files :
* /hive/trunk/build-common.xml
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
* /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java
* /hive/trunk/ql/src/test/queries/clientpositive/optrstat_groupby.q
* /hive/trunk/ql/src/test/results/clientpositive/optrstat_groupby.q.out
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Fix For: 0.10.0
>
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch, HIVE-3570.D5985.8.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488552#comment-13488552 ]
Phabricator commented on HIVE-3570:
-----------------------------------
njain has requested changes to the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
ignore my accept, can you try putting a comment
INLINE COMMENTS
ql/src/test/queries/clientpositive/OptrStatGroupBy.q:1 There is a bug where comments cannot come before a SET statement.
Can you try putting a comment before line 4 (select count(1) from src) ?
REVISION DETAIL
https://reviews.facebook.net/D5985
BRANCH
svn
To: njain, sambavim, kevinwilfong, satadru
Cc: JIRA, adobriyal
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489307#comment-13489307 ]
Phabricator commented on HIVE-3570:
-----------------------------------
njain has accepted the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
REVISION DETAIL
https://reviews.facebook.net/D5985
BRANCH
svn
To: njain, sambavim, kevinwilfong, satadru
Cc: JIRA, adobriyal
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch, HIVE-3570.D5985.8.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485871#comment-13485871 ]
Phabricator commented on HIVE-3570:
-----------------------------------
njain has commented on the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
INLINE COMMENTS
ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java:1 add apache header
ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java:29 add some comments - what are you trying to do ?
ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java:49 fix lint
ql/src/test/queries/clientpositive/OptrStatGroupBy.q:1 add some comments in the test.
What are you trying to achieve ?
ql/src/test/queries/clientpositive/OptrStatGroupBy.q:1 The test names start with a lower case letter - can you rename this test file ?
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java:997 lint ??
REVISION DETAIL
https://reviews.facebook.net/D5985
To: njain, sambavim, kevinwilfong, satadru
Cc: JIRA, adobriyal
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488550#comment-13488550 ]
Phabricator commented on HIVE-3570:
-----------------------------------
njain has accepted the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
INLINE COMMENTS
ql/src/test/results/clientpositive/optrstat_groupby.q.out:5 Outside the scope of this patch, but there seems to be a bug in num output rows.
It should be 1, not 0.
Can you file a new jira with the details ?
REVISION DETAIL
https://reviews.facebook.net/D5985
BRANCH
svn
To: njain, sambavim, kevinwilfong, satadru
Cc: JIRA, adobriyal
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478387#comment-13478387 ]
Phabricator commented on HIVE-3570:
-----------------------------------
satadru has commented on the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
@njain : I have done the changes and added an hook. Whenever I am executing the hook from outside(ie hive cli) everything works fine. But when it is run from the "ant test -Dtestcase=..." command, the Counter object in the Operator.java coming as null. (Probable reason: the unit test is not executing the query in actual hadoop cluster, without which counters are always null). Please suggest if there is any way to get around this problem. I tried searching for unit test involving counters in Operator.java, but couldn't find.
REVISION DETAIL
https://reviews.facebook.net/D5985
To: njain, satadru
Cc: JIRA
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Satadru Pan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Satadru Pan updated HIVE-3570:
------------------------------
Attachment: HIVE-3570.1.patch.txt
Patch for the task HIVE-3570
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3570:
------------------------------
Attachment: HIVE-3570.D5985.7.patch
satadru updated the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
Reviewers: njain, sambavim, kevinwilfong
Removing one unintended change build-common.
REVISION DETAIL
https://reviews.facebook.net/D5985
AFFECTED FILES
build-common.xml
ql/src/test/results/clientpositive/optrstat_groupby.q.out
ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java
ql/src/test/queries/clientpositive/optrstat_groupby.q
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
To: njain, sambavim, kevinwilfong, satadru
Cc: JIRA, adobriyal
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3570:
-----------------------------
Status: Open (was: Patch Available)
minor comments
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3570:
------------------------------
Attachment: HIVE-3570.D5985.6.patch
satadru updated the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
Reviewers: njain, sambavim, kevinwilfong
Updated the code according to the review comments.
REVISION DETAIL
https://reviews.facebook.net/D5985
AFFECTED FILES
build-common.xml
ql/src/test/results/clientpositive/optrstat_groupby.q.out
ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java
ql/src/test/queries/clientpositive/optrstat_groupby.q
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
To: njain, sambavim, kevinwilfong, satadru
Cc: JIRA, adobriyal
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475379#comment-13475379 ]
Phabricator commented on HIVE-3570:
-----------------------------------
njain has commented on the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
Please add a test.
Add a simple hook which prints the number of hashed rows.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java:1000 NUM_INPUT_ROWS are present in every operator.
You dont need it again.
REVISION DETAIL
https://reviews.facebook.net/D5985
To: njain, satadru
Cc: JIRA
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Satadru Pan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Satadru Pan updated HIVE-3570:
------------------------------
Status: Patch Available (was: Open)
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch, HIVE-3570.D5985.8.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Satadru Pan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Satadru Pan updated HIVE-3570:
------------------------------
Status: Patch Available (was: Open)
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3570:
------------------------------
Attachment: HIVE-3570.D5985.5.patch
satadru updated the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
Reviewers: njain
Final diff: After fixing a patch issue
REVISION DETAIL
https://reviews.facebook.net/D5985
AFFECTED FILES
build-common.xml
ql/src/test/results/clientpositive/OptrStatGroupBy.q.out
ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java
ql/src/test/queries/clientpositive/OptrStatGroupBy.q
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
To: njain, satadru
Cc: JIRA, adobriyal, sambavim
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489306#comment-13489306 ]
Namit Jain commented on HIVE-3570:
----------------------------------
+1
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch, HIVE-3570.D5985.8.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3570:
-----------------------------
Resolution: Fixed
Fix Version/s: 0.10.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed. Thanks Satadru
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Fix For: 0.10.0
>
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch, HIVE-3570.D5985.8.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain reassigned HIVE-3570:
--------------------------------
Assignee: Satadru Pan
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3570:
------------------------------
Attachment: HIVE-3570.D5985.4.patch
satadru updated the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
Reviewers: njain
Fix unit test issue mentioned above.
REVISION DETAIL
https://reviews.facebook.net/D5985
AFFECTED FILES
build-common.xml
ql/src/test/results/clientpositive/OptrStatGroupBy.q.out
ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java
ql/src/test/queries/clientpositive/OptrStatGroupBy.q
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
To: njain, satadru
Cc: JIRA, adobriyal, sambavim
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3570:
------------------------------
Attachment: HIVE-3570.D5985.3.patch
satadru updated the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
Reviewers: njain
Fix a patch issue in OptrStatGroupByHook.java which happened in the last revision.
REVISION DETAIL
https://reviews.facebook.net/D5985
AFFECTED FILES
ql/src/test/results/clientpositive/OptrStatGroupBy.q.out
ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java
ql/src/test/queries/clientpositive/OptrStatGroupBy.q
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
To: njain, satadru
Cc: JIRA, adobriyal, sambavim
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3570:
------------------------------
Attachment: HIVE-3570.D5985.1.patch
satadru added you to the CC list for the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
Reviewers: njain
TEST PLAN
Single box testing
REVISION DETAIL
https://reviews.facebook.net/D5985
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
To: JIRA
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Satadru Pan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Satadru Pan updated HIVE-3570:
------------------------------
Status: Patch Available (was: Open)
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3570) Add/fix facility to collect
operator specific statisticsin hive + add hash-in/hash-out counter for
GroupBy Optr
Posted by "Satadru Pan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HIVE-3570 started by Satadru Pan.
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488530#comment-13488530 ]
Phabricator commented on HIVE-3570:
-----------------------------------
satadru has commented on the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
INLINE COMMENTS
ql/src/test/queries/clientpositive/OptrStatGroupBy.q:1 Getting ant test failure whenever I am adding a comment line (-- comment) in the .q file. This seems to be some problem with the minimr test case.
REVISION DETAIL
https://reviews.facebook.net/D5985
To: njain, sambavim, kevinwilfong, satadru
Cc: JIRA, adobriyal
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3570:
------------------------------
Attachment: HIVE-3570.D5985.2.patch
satadru updated the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
Reviewers: njain
Update with CR comments by Namit
REVISION DETAIL
https://reviews.facebook.net/D5985
AFFECTED FILES
ql/src/test/results/clientpositive/OptrStatGroupBy.q.out
ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java
ql/src/test/queries/clientpositive/OptrStatGroupBy.q
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
To: njain, satadru
Cc: JIRA
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3570:
-----------------------------
Affects Version/s: (was: 0.9.0)
0.10.0
Status: Open (was: Patch Available)
minor comments on phabricator
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Satadru Pan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Satadru Pan updated HIVE-3570:
------------------------------
Status: Patch Available (was: In Progress)
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.9.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3570) Add/fix facility to collect operator
specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3570:
------------------------------
Attachment: HIVE-3570.D5985.8.patch
satadru updated the revision "HIVE-3570 [jira] Hive changes for Optr level stats".
Reviewers: njain, sambavim, kevinwilfong
Added the comment in the .q file, modified the test a little bit to avoid a new time depndent counter
REVISION DETAIL
https://reviews.facebook.net/D5985
AFFECTED FILES
build-common.xml
ql/src/test/results/clientpositive/optrstat_groupby.q.out
ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java
ql/src/test/queries/clientpositive/optrstat_groupby.q
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
To: njain, sambavim, kevinwilfong, satadru
Cc: JIRA, adobriyal
> Add/fix facility to collect operator specific statisticsin hive + add hash-in/hash-out counter for GroupBy Optr
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3570
> URL: https://issues.apache.org/jira/browse/HIVE-3570
> Project: Hive
> Issue Type: Improvement
> Components: Statistics
> Affects Versions: 0.10.0
> Reporter: Satadru Pan
> Assignee: Satadru Pan
> Priority: Minor
> Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, HIVE-3570.D5985.5.patch, HIVE-3570.D5985.6.patch, HIVE-3570.D5985.7.patch, HIVE-3570.D5985.8.patch
>
>
> Requirement: Collect Operator specific stats for hive queries. Use the counter framework available in Hive Operator.java to accomplish that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira