You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/08 07:09:46 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
AngersZhuuuu opened a new pull request #32089:
URL: https://github.com/apache/spark/pull/32089
### What changes were proposed in this pull request?
before when we use aggregate ordinal in group by expression and index position is a aggregate function, it will show error as
```
– !query
select a, b, sum(b) from data group by 3
– !query schema
struct<>
– !query output
org.apache.spark.sql.AnalysisException
aggregate functions are not allowed in GROUP BY, but found sum(data.b)
```
It't not clear enough refactor this error message in this pr
### Why are the changes needed?
refactor error message
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existed UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815746757
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41650/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r610439682
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1816,7 +1816,13 @@ class Analyzer(override val catalogManager: CatalogManager)
aggs: Seq[Expression]): Expression = expr match {
case ordinal @ UnresolvedOrdinal(index) =>
if (index > 0 && index <= aggs.size) {
- aggs(index - 1)
+ val ordinalExpr = aggs(index - 1)
+ if(ordinalExpr.find(_.isInstanceOf[AggregateExpression]).nonEmpty) {
Review comment:
nit: seems the indentation is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-817231223
**[Test build #137171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137171/testReport)** for PR 32089 at commit [`b37fef0`](https://github.com/apache/spark/commit/b37fef03033eadbba6512f24dcc6920954c45647).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816795747
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41719/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r610808277
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionRefersToAggregateFunctionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY $index refers to an expression that is or contains " +
+ "an aggregate function. Aggregate functions are not allowed in GROUP BY, " +
+ s"but got ${expr.sql}", t.origin.line, t.origin.startPosition)
+ }
+
def groupByPositionRangeError(index: Int, size: Int, t: TreeNode[_]): Throwable = {
new AnalysisException(s"GROUP BY position $index is not in select list " +
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
Review comment:
ditto
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1816,7 +1816,13 @@ class Analyzer(override val catalogManager: CatalogManager)
aggs: Seq[Expression]): Expression = expr match {
case ordinal @ UnresolvedOrdinal(index) =>
if (index > 0 && index <= aggs.size) {
Review comment:
We can use `withPosition` here so the error doesn't need a TreeNode field as a parameter.
```scala
withPosition(ordinal) {
...
throw QueryCompilationErrors.groupByPositionRefersToAggregateFunctionError(index, ordinalExpr)
}
```
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionRefersToAggregateFunctionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY $index refers to an expression that is or contains " +
+ "an aggregate function. Aggregate functions are not allowed in GROUP BY, " +
+ s"but got ${expr.sql}", t.origin.line, t.origin.startPosition)
Review comment:
Instead of using `t.origin.line` and `t.origin.startPosition`, we can wrap the code with `withPosition` so we can remove `t` here (see comment in Anayzer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r610481685
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1816,7 +1816,13 @@ class Analyzer(override val catalogManager: CatalogManager)
aggs: Seq[Expression]): Expression = expr match {
case ordinal @ UnresolvedOrdinal(index) =>
if (index > 0 && index <= aggs.size) {
- aggs(index - 1)
+ val ordinalExpr = aggs(index - 1)
+ if(ordinalExpr.find(_.isInstanceOf[AggregateExpression]).nonEmpty) {
Review comment:
> nit: seems the indentation is wrong.
Yea，updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815958185
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41663/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815861535
**[Test build #137082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137082/testReport)** for PR 32089 at commit [`45f64ee`](https://github.com/apache/spark/commit/45f64eee81a24b0f635240f14cce4a0e9be8aa05).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816081909
**[Test build #137082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137082/testReport)** for PR 32089 at commit [`45f64ee`](https://github.com/apache/spark/commit/45f64eee81a24b0f635240f14cce4a0e9be8aa05).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816208084
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137085/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r611111590
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1816,7 +1816,13 @@ class Analyzer(override val catalogManager: CatalogManager)
aggs: Seq[Expression]): Expression = expr match {
case ordinal @ UnresolvedOrdinal(index) =>
if (index > 0 && index <= aggs.size) {
Review comment:
@cloud-fan Do we need to unify all case to use `withPosition`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816764535
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41716/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r609772813
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionRefersToAggregateFunctionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY expression in position $index is an aggregate function. " +
Review comment:
`is an aggregate function` => `is or contains an aggregate function`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r610649518
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionRefersToAggregateFunctionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY $index refer to an expression that is or contains " +
Review comment:
refer -> refers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815900154
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815947712
**[Test build #137072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137072/testReport)** for PR 32089 at commit [`809bfd0`](https://github.com/apache/spark/commit/809bfd002f6c34b56043007de92d352b0f733edd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-817236111
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41749/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816921817
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137138/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816084990
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815675836
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41647/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816582124
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41704/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815553451
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41639/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816920417
**[Test build #137138 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137138/testReport)** for PR 32089 at commit [`f06bd4f`](https://github.com/apache/spark/commit/f06bd4fccbb82f5a7db86806f4c7574110ea4361).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815907764
**[Test build #137085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137085/testReport)** for PR 32089 at commit [`6b58b86`](https://github.com/apache/spark/commit/6b58b86db430e0709c9409649e0a5482f20fcb4a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815675836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815549266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815677233
**[Test build #137072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137072/testReport)** for PR 32089 at commit [`809bfd0`](https://github.com/apache/spark/commit/809bfd002f6c34b56043007de92d352b0f733edd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r610632276
##########
File path: sql/core/src/test/resources/sql-tests/results/group-by-ordinal.sql.out
##########
@@ -122,7 +122,7 @@ select a, b, sum(b) from data group by 3
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-aggregate functions are not allowed in GROUP BY, but found sum(data.b)
+GROUP BY expression in position 3 is or contains an aggregate function. Aggregate functions are not allowed in GROUP BY, but got sum(data.b) AS `sum(b)`; line 1 pos 39
Review comment:
I'm reading the error message again but feel it's hard to understand. How about
```
GROUP BY 3 refers to an expression that is or contains an aggregate function. Aggregate functions are not allowed ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816582159
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41704/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815638515
**[Test build #137069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137069/testReport)** for PR 32089 at commit [`dd201a8`](https://github.com/apache/spark/commit/dd201a84668bf4360991c30b8eba386322e68b15).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-817234869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815905570
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-817253121
**[Test build #137171 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137171/testReport)** for PR 32089 at commit [`b37fef0`](https://github.com/apache/spark/commit/b37fef03033eadbba6512f24dcc6920954c45647).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815955543
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137072/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815578953
Is the title correct? It seems this PR proposes to just make the error message clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r609460655
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionIsAggregateExpressionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY expression in position $index is an aggregate expression, " +
Review comment:
`an aggregate expression` -> `an aggregate function`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816579867
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41704/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815861535
**[Test build #137082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137082/testReport)** for PR 32089 at commit [`45f64ee`](https://github.com/apache/spark/commit/45f64eee81a24b0f635240f14cce4a0e9be8aa05).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r609462268
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionIsAggregateExpressionError(
Review comment:
`groupByPositionIsAggregateExpressionError` -> `groupByPositionRefersToAggregateFunctionError`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-817236111
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41749/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815510600
ping @cloud-fan @maropu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815738205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816947717
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137140/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816582159
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41704/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r609521768
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionIsAggregateExpressionError(
Review comment:
Done
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionIsAggregateExpressionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY expression in position $index is an aggregate expression, " +
Review comment:
Done
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionIsAggregateExpressionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY expression in position $index is an aggregate expression, " +
+ s"aggregate expression are not allowed in GROUP BY, but got `$expr`",
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r610642001
##########
File path: sql/core/src/test/resources/sql-tests/results/group-by-ordinal.sql.out
##########
@@ -122,7 +122,7 @@ select a, b, sum(b) from data group by 3
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-aggregate functions are not allowed in GROUP BY, but found sum(data.b)
+GROUP BY expression in position 3 is or contains an aggregate function. Aggregate functions are not allowed in GROUP BY, but got sum(data.b) AS `sum(b)`; line 1 pos 39
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-817231223
**[Test build #137171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137171/testReport)** for PR 32089 at commit [`b37fef0`](https://github.com/apache/spark/commit/b37fef03033eadbba6512f24dcc6920954c45647).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816716624
**[Test build #137138 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137138/testReport)** for PR 32089 at commit [`f06bd4f`](https://github.com/apache/spark/commit/f06bd4fccbb82f5a7db86806f4c7574110ea4361).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-817257215
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137171/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815675784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r610671797
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionRefersToAggregateFunctionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY $index refer to an expression that is or contains " +
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816764535
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41716/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816723549
**[Test build #137140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137140/testReport)** for PR 32089 at commit [`1f8a935`](https://github.com/apache/spark/commit/1f8a935cc8852a557075e4f3cd11498b142ad990).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815736969
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41650/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r611111481
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionRefersToAggregateFunctionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY $index refers to an expression that is or contains " +
+ "an aggregate function. Aggregate functions are not allowed in GROUP BY, " +
+ s"but got ${expr.sql}", t.origin.line, t.origin.startPosition)
Review comment:
> Instead of using `t.origin.line` and `t.origin.startPosition`, we can wrap the code with `withPosition` so we can remove `t` here (see comment in Anayzer).
Nice suggestion, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816552160
**[Test build #137126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137126/testReport)** for PR 32089 at commit [`a71fa68`](https://github.com/apache/spark/commit/a71fa68c6a7a0c6e05936b91da768b0a0cfa1ebe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815955543
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137072/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r609460226
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionIsAggregateExpressionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY expression in position $index is an aggregate expression, " +
+ s"aggregate expression are not allowed in GROUP BY, but got `$expr`",
Review comment:
`expr` -> `expr.sql`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816775714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816716624
**[Test build #137138 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137138/testReport)** for PR 32089 at commit [`f06bd4f`](https://github.com/apache/spark/commit/f06bd4fccbb82f5a7db86806f4c7574110ea4361).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815958127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815905570
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816947717
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137140/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r609784578
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionRefersToAggregateFunctionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY expression in position $index is an aggregate function. " +
Review comment:
> `is an aggregate function` => `is or contains an aggregate function`
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816715776
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137126/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815746860
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41650/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815677233
**[Test build #137072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137072/testReport)** for PR 32089 at commit [`809bfd0`](https://github.com/apache/spark/commit/809bfd002f6c34b56043007de92d352b0f733edd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816175807
**[Test build #137085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137085/testReport)** for PR 32089 at commit [`6b58b86`](https://github.com/apache/spark/commit/6b58b86db430e0709c9409649e0a5482f20fcb4a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816764485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815705135
**[Test build #137069 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137069/testReport)** for PR 32089 at commit [`dd201a8`](https://github.com/apache/spark/commit/dd201a84668bf4360991c30b8eba386322e68b15).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r609638317
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionRefersToAggregateFunctionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY expression in position $index is an aggregate function, " +
Review comment:
Nit: "aggregate function. Aggregate functions are not ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-817257215
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137171/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32089:
URL: https://github.com/apache/spark/pull/32089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815896591
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816208084
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137085/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816723549
**[Test build #137140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137140/testReport)** for PR 32089 at commit [`1f8a935`](https://github.com/apache/spark/commit/1f8a935cc8852a557075e4f3cd11498b142ad990).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816795747
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41719/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816084990
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816702318
**[Test build #137126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137126/testReport)** for PR 32089 at commit [`a71fa68`](https://github.com/apache/spark/commit/a71fa68c6a7a0c6e05936b91da768b0a0cfa1ebe).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32089:
URL: https://github.com/apache/spark/pull/32089#discussion_r609736958
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -268,6 +268,15 @@ private[spark] object QueryCompilationErrors {
s"(valid range is [1, $size])", t.origin.line, t.origin.startPosition)
}
+ def groupByPositionRefersToAggregateFunctionError(
+ index: Int,
+ expr: Expression,
+ t: TreeNode[_]): Throwable = {
+ new AnalysisException(s"GROUP BY expression in position $index is an aggregate function, " +
Review comment:
> Nit: "aggregate function. Aggregate functions are not ..."
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815958185
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41663/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815699270
**[Test build #137061 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137061/testReport)** for PR 32089 at commit [`540580b`](https://github.com/apache/spark/commit/540580bdd932f91c0e17ab750f7ec2542208a67f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816715776
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137126/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815553451
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41639/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816930095
**[Test build #137140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137140/testReport)** for PR 32089 at commit [`1f8a935`](https://github.com/apache/spark/commit/1f8a935cc8852a557075e4f3cd11498b142ad990).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-817441241
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Aggregate ordinal should judge is it contains aggregate function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815512974
**[Test build #137061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137061/testReport)** for PR 32089 at commit [`540580b`](https://github.com/apache/spark/commit/540580bdd932f91c0e17ab750f7ec2542208a67f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816552160
**[Test build #137126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137126/testReport)** for PR 32089 at commit [`a71fa68`](https://github.com/apache/spark/commit/a71fa68c6a7a0c6e05936b91da768b0a0cfa1ebe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815623907
> Is the title correct? It seems this PR proposes to just make the error message clearer.
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815746860
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41650/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815907764
**[Test build #137085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137085/testReport)** for PR 32089 at commit [`6b58b86`](https://github.com/apache/spark/commit/6b58b86db430e0709c9409649e0a5482f20fcb4a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32089: [SPARK-34986][SQL] Make an error msg clearer when ordinal numbers in group-by refer to agg funcs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-816921817
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137138/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32089: [SPARK-34986][SQL] Make exception clear when aggregate ordinal refer to aggregate function
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32089:
URL: https://github.com/apache/spark/pull/32089#issuecomment-815512974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org