[GitHub] [arrow-datafusion] Jefffrey commented on a diff in pull request #5210: Dataframe join_on method

["Jefffrey (via GitHub)" <gi...@apache.org>]

Jefffrey commented on code in PR #5210:
URL: https://github.com/apache/arrow-datafusion/pull/5210#discussion_r1098517157


##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -502,6 +505,25 @@ impl LogicalPlanBuilder {
             ));
         }
 
+        let filter = if let Some(expr) = filter {
+            // ambiguous check
+            ensure_any_column_reference_is_unambiguous(
+                &expr,
+                &[self.schema(), right.schema()],
+            )?;
+
+            // normalize all columns in expression
+            let using_columns = expr.to_columns()?;
+            let filter = normalize_col_with_schemas(
+                expr,
+                &[self.schema(), right.schema()],
+                &[using_columns],
+            )?;
+            Some(filter)
+        } else {
+            None
+        };
+

Review Comment:
   related to https://github.com/apache/arrow-datafusion/issues/4196
   
   fix bug where you could do dataframe join with ambiguous column for the filter expr
   
   instead of having the check done in both DataFrame join api and SQL planner join mod, unify by having check done inside the logical plan builder
   
   this is technically an unrelated fix to the actual issue, so i can extract into separate issue if needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org