You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/12/27 12:43:04 UTC
[PR] test with sslcontext [incubator-pekko-grpc]
pjfanning opened a new pull request, #205:
URL: https://github.com/apache/incubator-pekko-grpc/pull/205
update tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] test with sslcontext [incubator-pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #205:
URL: https://github.com/apache/incubator-pekko-grpc/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] test with sslcontext [incubator-pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #205:
URL: https://github.com/apache/incubator-pekko-grpc/pull/205#discussion_r1437167632
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/interop/PekkoGrpcScalaClientTester.scala:
##########
@@ -41,21 +41,29 @@ import scala.util.control.NoStackTrace
* The same implementation is also be found as part of the 'scripted' tests at
* /sbt-plugin/src/sbt-test/gen-scala-server/00-interop/src/test/scala/org/apache/pekko/grpc/PekkoGrpcClientTester.scala
*/
-class PekkoGrpcScalaClientTester(val settings: Settings, backend: String)(implicit system: ActorSystem)
- extends ClientTester {
+class PekkoGrpcScalaClientTester(val settings: Settings, backend: String, testWithSslContext: Boolean)(
Review Comment:
It is test code. And the SSL context is created inside this class. Not outside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] test with sslcontext [incubator-pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #205:
URL: https://github.com/apache/incubator-pekko-grpc/pull/205#discussion_r1437168273
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/interop/PekkoGrpcScalaClientTester.scala:
##########
@@ -41,21 +41,29 @@ import scala.util.control.NoStackTrace
* The same implementation is also be found as part of the 'scripted' tests at
* /sbt-plugin/src/sbt-test/gen-scala-server/00-interop/src/test/scala/org/apache/pekko/grpc/PekkoGrpcClientTester.scala
*/
-class PekkoGrpcScalaClientTester(val settings: Settings, backend: String)(implicit system: ActorSystem)
- extends ClientTester {
+class PekkoGrpcScalaClientTester(val settings: Settings, backend: String, testWithSslContext: Boolean)(
Review Comment:
When we have a use case for creating the SSL context outside - we can change then. Seems bad to overengineer test code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] test with sslcontext [incubator-pekko-grpc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #205:
URL: https://github.com/apache/incubator-pekko-grpc/pull/205#discussion_r1437163469
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/interop/PekkoGrpcScalaClientTester.scala:
##########
@@ -41,21 +41,29 @@ import scala.util.control.NoStackTrace
* The same implementation is also be found as part of the 'scripted' tests at
* /sbt-plugin/src/sbt-test/gen-scala-server/00-interop/src/test/scala/org/apache/pekko/grpc/PekkoGrpcClientTester.scala
*/
-class PekkoGrpcScalaClientTester(val settings: Settings, backend: String)(implicit system: ActorSystem)
- extends ClientTester {
+class PekkoGrpcScalaClientTester(val settings: Settings, backend: String, testWithSslContext: Boolean)(
Review Comment:
maybe better with a trait
SslContextProvider, and the false can be expressed by returning None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org