[GitHub] [airflow] potiuk commented on a change in pull request #6449: [AIRFLOW-5793] add test to detect multiple alembic revision heads

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #6449: [AIRFLOW-5793] add test to detect multiple alembic revision heads
URL: https://github.com/apache/airflow/pull/6449#discussion_r339361926
 
 

 ##########
 File path: tests/test_alembic.py
 ##########
 @@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import unittest
+
+from alembic.config import Config
+from alembic.script import ScriptDirectory
+
+
+class TestAlembic(unittest.TestCase):
+
+    def test_only_single_head_revision_in_migrations(self):
 
 Review comment:
   I think the PR template is already pretty bloated :) (I think we should somehow simplify this). I found it initially useful, but then it becomes more and more tiresome. Let's not make it more complex.
   
   I think everything that is now in the template should be automatically verified by the checks in CI and commiters should not even think about checking it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services