You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ravi Knox (JIRA)" <ji...@apache.org> on 2016/07/01 12:34:11 UTC
[jira] [Created] (WICKET-6192) Remove
recreateBookmarkablePagesAfterExpiry ceck in
AbstractBookmarkableMapper#mapHandler
Ravi Knox created WICKET-6192:
---------------------------------
Summary: Remove recreateBookmarkablePagesAfterExpiry ceck in AbstractBookmarkableMapper#mapHandler
Key: WICKET-6192
URL: https://issues.apache.org/jira/browse/WICKET-6192
Project: Wicket
Issue Type: Bug
Reporter: Ravi Knox
In a nutshell that's what we try to archive:
Save a cookie on a client browser under the path of the current page.
The page does have a mandatory named parameter!
If the Session expires. The SessionExpiredPage will read the cookie and start a redirect.
After resolving Ticket [WICKET-6182|https://issues.apache.org/jira/browse/WICKET-6182]:
What happens now is that by the time the AbstractBookmarkableMapper wants to generate the URL of the component, before including the existent parameters,
it does an getRecreateMountedPagesAfterExpiry() check ([see here|https://github.com/apache/wicket/blob/f71a2d33c2ff9dbb669066a3dfc7b58229824b0e/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/AbstractBookmarkableMapper.java#L479]). which answers false and the existing parameters are not added to the new UrlInfo object.
That in return will lead to a failure when calling setPlaceholders(copy, url) ([see here|https://github.com/apache/wicket/blob/f71a2d33c2ff9dbb669066a3dfc7b58229824b0e/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/MountedMapper.java#L206]) and results in a null url return value, that lets wicket default to the generic URL we had before.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)