You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Srikanth Sundarrajan <sr...@hotmail.com> on 2014/01/30 06:49:26 UTC
Review Request 17526: FALCON-221 Logmover is not copying all action level
logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17526/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-221
https://issues.apache.org/jira/browse/FALCON-221
Repository: falcon-git
Description
-------
Logmover is not copying all action level logs
Diffs
-----
oozie/pom.xml a6514e4
oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java PRE-CREATION
oozie/src/main/java/org/apache/falcon/logging/LogMover.java afdc36d
oozie/src/main/java/org/apache/falcon/logging/TaskLogURLRetriever.java PRE-CREATION
oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java PRE-CREATION
Diff: https://reviews.apache.org/r/17526/diff/
Testing
-------
Thanks,
Srikanth Sundarrajan
Re: Review Request 17526: FALCON-221 Logmover is not copying all action
level logs
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
> On Jan. 30, 2014, 8:08 a.m., Amareshwari Sriramadasu wrote:
> > oozie/src/main/java/org/apache/falcon/logging/LogMover.java, line 213
> > <https://reviews.apache.org/r/17526/diff/1/?file=454219#file454219line213>
> >
> > should we create the TaskLogURLRetriever once and use it across all getTTlogURL calls?
It is typically called only once.
> On Jan. 30, 2014, 8:08 a.m., Amareshwari Sriramadasu wrote:
> > oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java, line 81
> > <https://reviews.apache.org/r/17526/diff/1/?file=454221#file454221line81>
> >
> > do you want to use JobHistory.JobInfo.decodeJobHistoryFileName ?
Yes. Makes sense. Will upload revised patch with this change
- Srikanth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17526/#review33205
-----------------------------------------------------------
On Jan. 30, 2014, 5:49 a.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17526/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 5:49 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-221
> https://issues.apache.org/jira/browse/FALCON-221
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Logmover is not copying all action level logs
>
>
> Diffs
> -----
>
> oozie/pom.xml a6514e4
> oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java PRE-CREATION
> oozie/src/main/java/org/apache/falcon/logging/LogMover.java afdc36d
> oozie/src/main/java/org/apache/falcon/logging/TaskLogURLRetriever.java PRE-CREATION
> oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17526/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 17526: FALCON-221 Logmover is not copying all action
level logs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17526/#review33205
-----------------------------------------------------------
getFromHistory() and getHistoryFile() code looks fine. Couple of minor comments posted.
oozie/src/main/java/org/apache/falcon/logging/LogMover.java
<https://reviews.apache.org/r/17526/#comment62568>
should we create the TaskLogURLRetriever once and use it across all getTTlogURL calls?
oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java
<https://reviews.apache.org/r/17526/#comment62567>
do you want to use JobHistory.JobInfo.decodeJobHistoryFileName ?
- Amareshwari Sriramadasu
On Jan. 30, 2014, 5:49 a.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17526/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 5:49 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-221
> https://issues.apache.org/jira/browse/FALCON-221
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Logmover is not copying all action level logs
>
>
> Diffs
> -----
>
> oozie/pom.xml a6514e4
> oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java PRE-CREATION
> oozie/src/main/java/org/apache/falcon/logging/LogMover.java afdc36d
> oozie/src/main/java/org/apache/falcon/logging/TaskLogURLRetriever.java PRE-CREATION
> oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17526/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 17526: FALCON-221 Logmover is not copying all action
level logs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17526/#review33209
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Jan. 30, 2014, 8:20 a.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17526/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 8:20 a.m.)
>
>
> Review request for Falcon and Amareshwari Sriramadasu.
>
>
> Bugs: FALCON-221
> https://issues.apache.org/jira/browse/FALCON-221
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Logmover is not copying all action level logs
>
>
> Diffs
> -----
>
> oozie/pom.xml a6514e4
> oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java PRE-CREATION
> oozie/src/main/java/org/apache/falcon/logging/LogMover.java afdc36d
> oozie/src/main/java/org/apache/falcon/logging/TaskLogURLRetriever.java PRE-CREATION
> oozie/src/versioned-src/v1/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17526/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 17526: FALCON-221 Logmover is not copying all action
level logs
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17526/
-----------------------------------------------------------
(Updated Jan. 30, 2014, 8:20 a.m.)
Review request for Falcon and Amareshwari Sriramadasu.
Bugs: FALCON-221
https://issues.apache.org/jira/browse/FALCON-221
Repository: falcon-git
Description
-------
Logmover is not copying all action level logs
Diffs (updated)
-----
oozie/pom.xml a6514e4
oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java PRE-CREATION
oozie/src/main/java/org/apache/falcon/logging/LogMover.java afdc36d
oozie/src/main/java/org/apache/falcon/logging/TaskLogURLRetriever.java PRE-CREATION
oozie/src/versioned-src/v1/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java PRE-CREATION
Diff: https://reviews.apache.org/r/17526/diff/
Testing
-------
Thanks,
Srikanth Sundarrajan
Re: Review Request 17526: FALCON-221 Logmover is not copying all action
level logs
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17526/
-----------------------------------------------------------
(Updated Jan. 30, 2014, 8:15 a.m.)
Review request for Falcon and Amareshwari Sriramadasu.
Changes
-------
Patch revised as per review comment
Bugs: FALCON-221
https://issues.apache.org/jira/browse/FALCON-221
Repository: falcon-git
Description
-------
Logmover is not copying all action level logs
Diffs (updated)
-----
oozie/pom.xml a6514e4
oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java PRE-CREATION
oozie/src/main/java/org/apache/falcon/logging/LogMover.java afdc36d
oozie/src/main/java/org/apache/falcon/logging/TaskLogURLRetriever.java PRE-CREATION
oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java PRE-CREATION
Diff: https://reviews.apache.org/r/17526/diff/
Testing
-------
Thanks,
Srikanth Sundarrajan
Re: Review Request 17526: FALCON-221 Logmover is not copying all action
level logs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17526/#review33208
-----------------------------------------------------------
oozie/pom.xml
<https://reviews.apache.org/r/17526/#comment62572>
Not sure what this build plugin will do, but the new class is added in oozie/src/versioned-src/v2/, whereas the source here says v1
- Amareshwari Sriramadasu
On Jan. 30, 2014, 5:49 a.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17526/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 5:49 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-221
> https://issues.apache.org/jira/browse/FALCON-221
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Logmover is not copying all action level logs
>
>
> Diffs
> -----
>
> oozie/pom.xml a6514e4
> oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java PRE-CREATION
> oozie/src/main/java/org/apache/falcon/logging/LogMover.java afdc36d
> oozie/src/main/java/org/apache/falcon/logging/TaskLogURLRetriever.java PRE-CREATION
> oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17526/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>