You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bs...@apache.org on 2017/09/13 22:55:17 UTC
[geode] branch develop updated: GEODE-3562 CI Failure:
JSONCodecJUnitTest.testSimpleJSONEncode fails on Windows
This is an automated email from the ASF dual-hosted git repository.
bschuchardt pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push:
new a4320f7 GEODE-3562 CI Failure: JSONCodecJUnitTest.testSimpleJSONEncode fails on Windows
a4320f7 is described below
commit a4320f781bca265480aa1b943a17f080c29a0be4
Author: Bruce Schuchardt <bs...@pivotal.io>
AuthorDate: Wed Sep 13 15:43:25 2017 -0700
GEODE-3562 CI Failure: JSONCodecJUnitTest.testSimpleJSONEncode fails on Windows
modified the test to use platform-specific line terminators in the
json document. Tested on MacOS and Windows.
---
.../org/apache/geode/serialization/codec/JSONCodecJUnitTest.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/geode-protobuf/src/test/java/org/apache/geode/serialization/codec/JSONCodecJUnitTest.java b/geode-protobuf/src/test/java/org/apache/geode/serialization/codec/JSONCodecJUnitTest.java
index 7174855..2b5e5bd 100644
--- a/geode-protobuf/src/test/java/org/apache/geode/serialization/codec/JSONCodecJUnitTest.java
+++ b/geode-protobuf/src/test/java/org/apache/geode/serialization/codec/JSONCodecJUnitTest.java
@@ -91,8 +91,9 @@ public class JSONCodecJUnitTest {
byte[] encodedJSONByte = new JSONCodec().encode(pdxInstance);
- String expectedJsonString =
- "{\n" + " \"string\" : \"someString\",\n" + " \"boolean\" : true\n" + "}";
+ String lineSeparator = System.lineSeparator();
+ String expectedJsonString = "{" + lineSeparator + "" + " \"string\" : \"someString\","
+ + lineSeparator + "" + " \"boolean\" : true" + lineSeparator + "}";
assertArrayEquals(expectedJsonString.getBytes(), encodedJSONByte);
}
--
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <co...@geode.apache.org>'].