You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com> on 2016/06/22 23:30:37 UTC
Review Request 49116: SAMZA-889: Change log not working properly with
In memory Store
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49116/
-----------------------------------------------------------
Review request for samza and Navina Ramesh.
Bugs: SAMZA-889
https://issues.apache.org/jira/browse/SAMZA-889
Repository: samza
Description
-------
SAMZA-889: Change log not working properly with In memory Store
Diffs
-----
checkstyle/import-control.xml d0a5c6682aab1cd363c8e16d977f624857a096fc
samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java 5463648fd01e0cba52fa9bd9a33b247e7014cfde
samza-api/src/main/java/org/apache/samza/storage/StorageEngineFactory.java adb62643a311e25fb4fed91c39e1a75cd5664b17
samza-api/src/main/java/org/apache/samza/storage/StoreProperties.java PRE-CREATION
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 5cbdb4b55cbb96fea15b299e5e2ab26710a19f7f
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala.orig 086531e4d72e88d21735db6a5afd1c7e84b6c2e5
samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 2a3535e8017e971ea01749709800cbfdfa254992
samza-core/src/test/java/org/apache/samza/storage/MockStorageEngine.java b90ea87b7e575e646c58ddfb5a53ced9ed04a880
samza-core/src/test/java/org/apache/samza/storage/MockStorageEngineFactory.java c00c4547307f5a8b401c6bb6438eaa7fb8a38651
samza-core/src/test/java/org/apache/samza/storage/TestStorageRecovery.java 13f4fa97d42b02e54634c8de1575118ca0433fe8
samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala e126481b4543111ac8b16106d41bc4c1d5f504d5
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala dae6e35d1ba75daf5c816bccbc625c623a44d3b2
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 38c8fa088112ad8e273d912719652f3b2e4e0432
samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala 391cf89b05f90ececae63160cd3cb9c811e4ab66
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala e5a66a4770b9553a1cc48fbb505f52d123c6c754
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 23f8a1a6bee8ef38e0640a4e90778e53d982deeb
Diff: https://reviews.apache.org/r/49116/diff/
Testing
-------
Local build w/ unit tests
Thanks,
Yi Pan (Data Infrastructure)
Re: Review Request 49116: SAMZA-889: Change log not working properly
with In memory Store
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49116/#review139176
-----------------------------------------------------------
Ship it!
Changes look good, Yi! +1 Thanks for rebasing!
- Navina Ramesh
On June 22, 2016, 11:32 p.m., Yi Pan (Data Infrastructure) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49116/
> -----------------------------------------------------------
>
> (Updated June 22, 2016, 11:32 p.m.)
>
>
> Review request for samza and Navina Ramesh.
>
>
> Bugs: SAMZA-889
> https://issues.apache.org/jira/browse/SAMZA-889
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-889: Change log not working properly with In memory Store
>
>
> Diffs
> -----
>
> checkstyle/import-control.xml d0a5c6682aab1cd363c8e16d977f624857a096fc
> samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java 5463648fd01e0cba52fa9bd9a33b247e7014cfde
> samza-api/src/main/java/org/apache/samza/storage/StorageEngineFactory.java adb62643a311e25fb4fed91c39e1a75cd5664b17
> samza-api/src/main/java/org/apache/samza/storage/StoreProperties.java PRE-CREATION
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 5cbdb4b55cbb96fea15b299e5e2ab26710a19f7f
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala.orig 086531e4d72e88d21735db6a5afd1c7e84b6c2e5
> samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 2a3535e8017e971ea01749709800cbfdfa254992
> samza-core/src/test/java/org/apache/samza/storage/MockStorageEngine.java b90ea87b7e575e646c58ddfb5a53ced9ed04a880
> samza-core/src/test/java/org/apache/samza/storage/MockStorageEngineFactory.java c00c4547307f5a8b401c6bb6438eaa7fb8a38651
> samza-core/src/test/java/org/apache/samza/storage/TestStorageRecovery.java 13f4fa97d42b02e54634c8de1575118ca0433fe8
> samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala e126481b4543111ac8b16106d41bc4c1d5f504d5
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala dae6e35d1ba75daf5c816bccbc625c623a44d3b2
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 38c8fa088112ad8e273d912719652f3b2e4e0432
> samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala 391cf89b05f90ececae63160cd3cb9c811e4ab66
> samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala e5a66a4770b9553a1cc48fbb505f52d123c6c754
> samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 23f8a1a6bee8ef38e0640a4e90778e53d982deeb
>
> Diff: https://reviews.apache.org/r/49116/diff/
>
>
> Testing
> -------
>
> Local build w/ unit tests
>
>
> Thanks,
>
> Yi Pan (Data Infrastructure)
>
>
Re: Review Request 49116: SAMZA-889: Change log not working properly
with In memory Store
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49116/
-----------------------------------------------------------
(Updated June 22, 2016, 11:32 p.m.)
Review request for samza and Navina Ramesh.
Changes
-------
Fix test code.
Bugs: SAMZA-889
https://issues.apache.org/jira/browse/SAMZA-889
Repository: samza
Description
-------
SAMZA-889: Change log not working properly with In memory Store
Diffs (updated)
-----
checkstyle/import-control.xml d0a5c6682aab1cd363c8e16d977f624857a096fc
samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java 5463648fd01e0cba52fa9bd9a33b247e7014cfde
samza-api/src/main/java/org/apache/samza/storage/StorageEngineFactory.java adb62643a311e25fb4fed91c39e1a75cd5664b17
samza-api/src/main/java/org/apache/samza/storage/StoreProperties.java PRE-CREATION
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 5cbdb4b55cbb96fea15b299e5e2ab26710a19f7f
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala.orig 086531e4d72e88d21735db6a5afd1c7e84b6c2e5
samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 2a3535e8017e971ea01749709800cbfdfa254992
samza-core/src/test/java/org/apache/samza/storage/MockStorageEngine.java b90ea87b7e575e646c58ddfb5a53ced9ed04a880
samza-core/src/test/java/org/apache/samza/storage/MockStorageEngineFactory.java c00c4547307f5a8b401c6bb6438eaa7fb8a38651
samza-core/src/test/java/org/apache/samza/storage/TestStorageRecovery.java 13f4fa97d42b02e54634c8de1575118ca0433fe8
samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala e126481b4543111ac8b16106d41bc4c1d5f504d5
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala dae6e35d1ba75daf5c816bccbc625c623a44d3b2
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 38c8fa088112ad8e273d912719652f3b2e4e0432
samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala 391cf89b05f90ececae63160cd3cb9c811e4ab66
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala e5a66a4770b9553a1cc48fbb505f52d123c6c754
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 23f8a1a6bee8ef38e0640a4e90778e53d982deeb
Diff: https://reviews.apache.org/r/49116/diff/
Testing
-------
Local build w/ unit tests
Thanks,
Yi Pan (Data Infrastructure)