You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by blrunner <gi...@git.apache.org> on 2014/11/20 09:22:04 UTC

[GitHub] tajo pull request: TAJO-1053: ADD PARTITIONS for HCatalogStore.

GitHub user blrunner opened a pull request:

    https://github.com/apache/tajo/pull/263

    TAJO-1053: ADD PARTITIONS for HCatalogStore.

    I tried to resolve this issue. But unfortunately, current tajo doesn't provide ALTER PARTITION command. In addition, hive doesn't support a api for repair all partitions at a time. So, there is a one way which scan all directories of a tajo and run ALTER PARITION api for each all partitions. But it is very inefficient way and it will be a cause of HiveMetaStore low performance. Thus, we need to guide our users to run msck command on hive. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/blrunner/tajo TAJO-1053

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #263
    
----
commit e90a003c1d86ef4bbe484906cd4f329c84d6bdb5
Author: JaeHwa Jung <bl...@apache.org>
Date:   2014-11-20T08:15:17Z

    TAJO-1053: ADD PARTITIONS for HCatalogStore.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1053: ADD PARTITIONS for HCatalogStore.

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/263#discussion_r20838803
  
    --- Diff: tajo-docs/src/main/sphinx/hcatalog_integration.rst ---
    @@ -37,3 +37,16 @@ Finally, you should specify HCatalogStore as Tajo catalog driver class in ``conf
         <name>tajo.catalog.store.class</name>
         <value>org.apache.tajo.catalog.store.HCatalogStore</value>
       </property>
    +
    +.. note::
    +
    +  Hive stores a list of partitions for each table in its metastore. If new partitions are
    +  directly added to HDFS, HiveMetastore will not able aware of these partitions unless the user
    +  ``ALTER TABLE table_name ADD PARTITION`` commands on each of the newly added partitions or
    +  ``MSCK REPAIR TABLE  table_name`` command.
    +
    +  But current tajo doesn't provide ``ADD PARTITION`` command and hive doesn't provide a api for
    --- End diff --
    
    ```a api``` should be an api.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1053: ADD PARTITIONS for HCatalogStore.

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/263#issuecomment-64318304
  
    @hyunsik , thanks for quick review. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1053: ADD PARTITIONS for HCatalogStore.

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/263#issuecomment-64316480
  
    +1 ship it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1053: ADD PARTITIONS for HCatalogStore.

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/263#issuecomment-64300228
  
    Thanks @hyunsik .
    I've just updated it. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1053: ADD PARTITIONS for HCatalogStore.

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner closed the pull request at:

    https://github.com/apache/tajo/pull/263


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---