[GitHub] [camel-k] astefanutti commented on a change in pull request #2535: Fix #2530: fix type and do not add cross-namespace owner references

[GitBox <gi...@apache.org>]

astefanutti commented on a change in pull request #2535:
URL: https://github.com/apache/camel-k/pull/2535#discussion_r678926692



##########
File path: pkg/trait/pull_secret.go
##########
@@ -122,6 +122,10 @@ func (t *pullSecretTrait) newImagePullerRoleBinding(e *Environment) *rbacv1.Role
 		serviceAccount = "default"
 	}
 	return &rbacv1.RoleBinding{

Review comment:
       I wonder if there would be a logical owner reference for that resource, so that it gets garbage collected when no needed anymore. Maybe the IntegrationPlatform could be the owner?
   
   Also I think there is an issue when two Integrations in the same namespace use different service accounts, as the RoleBinding will be updated with the last one. I wonder if a single RoleBinding maintaining all the subjects for the global platform could work, but that'd probably be more involved to implement.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org