[GitHub] [spark] beliefer commented on a change in pull request #24529: [SPARK-27634][Structured Streaming] deleteCheckpointOnStop should be configurable

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #24529: [SPARK-27634][Structured Streaming] deleteCheckpointOnStop should be configurable
URL: https://github.com/apache/spark/pull/24529#discussion_r281440771
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
 ##########
 @@ -215,7 +215,7 @@ class StreamingQueryManager private[sql] (sparkSession: SparkSession) extends Lo
       recoverFromCheckpointLocation: Boolean,
       trigger: Trigger,
       triggerClock: Clock): StreamingQueryWrapper = {
-    var deleteCheckpointOnStop = false
+    var deleteCheckpointOnStop = sparkSession.sessionState.conf.isDeleteCheckpoint.getOrElse(false)
 
 Review comment:
   I checked the code, I think the origin design do not want to delete the checkpoint directory unless you have not specify one.
   If you want control delete behavior, not specify the checkpoint directory. Temp directory will be delete after app stop.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org