You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/01 21:21:34 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19382: Numpy unique repeat indices large tensor checks
Zha0q1 opened a new pull request #19382:
URL: https://github.com/apache/incubator-mxnet/pull/19382
This pr adds large tensor checks to numpy unique, indices, and repeat. Those ops are running very slowly on large tensors (>20mins) so we might just block such use cases. If in the future there is a valid LT use case we will need to consider optimize the performance and remove those size checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 merged pull request #19382: Numpy unique repeat indices large tensor checks
Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #19382:
URL: https://github.com/apache/incubator-mxnet/pull/19382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19382: Numpy unique repeat indices large tensor checks
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19382:
URL: https://github.com/apache/incubator-mxnet/pull/19382#discussion_r533710938
##########
File path: src/operator/numpy/np_init_op.cc
##########
@@ -47,11 +47,13 @@ inline bool NumpyIndicesShape(const nnvm::NodeAttrs& attrs,
<< "_npi_indices dimensions the number of dim must not be less than 0";
mxnet::TShape param_dim = param.dimensions;
if (!shape_is_known(param_dim)) return false;
+ CHECK_LT(param_dim.Size(), INT32_MAX) << "ValueError: np.indices does not support large"
Review comment:
can you change the message to “does not support input(s) containing elements >=2^31”
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 closed pull request #19382: Numpy unique repeat indices large tensor checks
Posted by GitBox <gi...@apache.org>.
Zha0q1 closed pull request #19382:
URL: https://github.com/apache/incubator-mxnet/pull/19382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19382: Numpy unique repeat indices large tensor checks
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19382:
URL: https://github.com/apache/incubator-mxnet/pull/19382#issuecomment-712483714
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, unix-cpu, sanity, windows-cpu, edge, clang, windows-gpu, unix-gpu, miscellaneous, centos-cpu, centos-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org