[GitHub] [lucene-solr] ctargett commented on a change in pull request #1923: SOLR-14900: Reference Guide build cleanup/module upgrade

[GitBox <gi...@apache.org>]

ctargett commented on a change in pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923#discussion_r495883260



##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -90,14 +90,14 @@ dependencies {
     depVer('org.apache.zookeeper:zookeeper')
 
     // jekyll dependencies
-    gems 'rubygems:jekyll:3.5.2'
+    gems 'rubygems:jekyll:4.1.1'

Review comment:
       There are significant changes between Jekyll 3 and 4 and we haven't upgraded to it yet because it needs some careful analysis and fixing. In the past attempts to build with Jekyll 4 have failed. I don't see evidence in this PR that you have done sufficient testing for me to feel confident that this is OK.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org