You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/25 00:37:33 UTC

[GitHub] [beam] robertwb commented on a change in pull request #11185: [BEAM-8019] Some generalizations to support cross-language transforms.

robertwb commented on a change in pull request #11185: [BEAM-8019] Some generalizations to support cross-language transforms.
URL: https://github.com/apache/beam/pull/11185#discussion_r397543519
 
 

 ##########
 File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
 ##########
 @@ -380,7 +381,12 @@ def visit_transform(self, transform_node):
         # pylint: disable=wrong-import-order, wrong-import-position
         from apache_beam import Flatten
         if isinstance(transform_node.transform, Flatten):
-          output_pcoll = transform_node.outputs[None]
+          from apache_beam.runners.portability.fn_api_runner.translations \
 
 Review comment:
   If you want to use this, let's put it in a shared utils file. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services