You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/07/12 14:17:08 UTC

Review Request 67897: Updated two tests to verfiy freezer subsystem.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67897/
-----------------------------------------------------------

Review request for mesos and Gilbert Song.


Bugs: MESOS-9070
    https://issues.apache.org/jira/browse/MESOS-9070


Repository: mesos


Description
-------

Updated two tests to verfiy freezer subsystem.


Diffs
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp 3041640c795c8d934870476cf581d704fbcab8c1 


Diff: https://reviews.apache.org/r/67897/diff/1/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Re: Review Request 67897: Updated two tests to verfiy freezer subsystem.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67897/#review206221
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On July 12, 2018, 7:17 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67897/
> -----------------------------------------------------------
> 
> (Updated July 12, 2018, 7:17 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9070
>     https://issues.apache.org/jira/browse/MESOS-9070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated two tests to verfiy freezer subsystem.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 3041640c795c8d934870476cf581d704fbcab8c1 
> 
> 
> Diff: https://reviews.apache.org/r/67897/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 67897: Updated two tests to verfiy freezer subsystem.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67897/#review206013
-----------------------------------------------------------



PASS: Mesos patch 67897 was successfully built and tested.

Reviews applied: `['67896', '67897']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1909/mesos-review-67897

- Mesos Reviewbot Windows


On July 12, 2018, 2:17 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67897/
> -----------------------------------------------------------
> 
> (Updated July 12, 2018, 2:17 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9070
>     https://issues.apache.org/jira/browse/MESOS-9070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated two tests to verfiy freezer subsystem.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 3041640c795c8d934870476cf581d704fbcab8c1 
> 
> 
> Diff: https://reviews.apache.org/r/67897/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 67897: Updated two tests to verfiy freezer subsystem.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67897/#review206085
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67896, 67897]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 12, 2018, 2:17 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67897/
> -----------------------------------------------------------
> 
> (Updated July 12, 2018, 2:17 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9070
>     https://issues.apache.org/jira/browse/MESOS-9070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated two tests to verfiy freezer subsystem.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 3041640c795c8d934870476cf581d704fbcab8c1 
> 
> 
> Diff: https://reviews.apache.org/r/67897/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>