You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/03/08 14:32:10 UTC

[PR] RATIS-2425. make_rc.sh does not set version in ratis-bom [ratis]

adoroszlai opened a new pull request, #1367:
URL: https://github.com/apache/ratis/pull/1367

   ## What changes were proposed in this pull request?
   
   Let `make_rc.sh` change version in all modules.  Fail the step if `ratis-bom/pom.xml` is unchanged.
   
   https://issues.apache.org/jira/browse/RATIS-2425
   
   ## How was this patch tested?
   
   Locally tested the sanity check without adding `-DprocessAllModules`.
   
   ```bash
   $ ./dev-support/make_rc.sh 1-prepare-src
   ...
   ++ grep -q ratis-bom/pom.xml
   ++ git diff --name-only
   ++ echo 'ratis-bom not updated by `mvn versions:set`'
   ratis-bom not updated by `mvn versions:set`
   ++ exit 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2425. make_rc.sh does not set version in ratis-bom [ratis]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1367:
URL: https://github.com/apache/ratis/pull/1367#issuecomment-4055826183

   Sure, please feel free to remove it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2425. make_rc.sh does not set version in ratis-bom [ratis]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1367:
URL: https://github.com/apache/ratis/pull/1367#issuecomment-4019589201

   Thanks @szetszwo for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2425. make_rc.sh does not set version in ratis-bom [ratis]

Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on PR #1367:
URL: https://github.com/apache/ratis/pull/1367#issuecomment-4056073313

   Just send the email @adoroszlai 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2425. make_rc.sh does not set version in ratis-bom [ratis]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1367:
URL: https://github.com/apache/ratis/pull/1367#issuecomment-4055837853

   BTW, since there was no vote about rc1, do we still need to bump to rc2, or can simply replace rc1 artifacts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2425. make_rc.sh does not set version in ratis-bom [ratis]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #1367:
URL: https://github.com/apache/ratis/pull/1367


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org