[GitHub] [jclouds] gaul commented on pull request #86: Initial cleanup of maven set up in the parents' module

[GitBox <gi...@apache.org>]

gaul commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770364529


   Sorry about my delayed response.  I appreciate breaking out the commits and I follow the logic from the detailed messages.  However I am concerned with upgrading the Guava version:
   
   > Note: In an OSGi runtime, Guice version 4.2.3 expects Guava with an exact version of 27.1-jre. For now, higher versions of Guava are not possible.
   
   A later commit message says:
   
   > The version of Guice built into JClouds is 4.2.3. Increasing to this version number was not the subject of the current branch.
   >
   > To avoid backward compatibility problems between Guice and Guava (e.g. Guice 4.2.3 -> Guava 24) this means that the version of Guava integrated in JClouds must be at least version 27.1. Guice puts this in its dependencies.
   
   Prior to this PR, jclouds supported Guava 22-30, or at least we believed that this range worked.  Is it possible to continue this support, possibly by downgrading Guice?  I am not opposed to upgrading but I want to understand if there are other options since Guava upgrades have previously caused user complaints and rollbacks.
   
   Also the last message for okio confuses me:
   
   > In the following feature, the version of the "ok" framework has been significantly increased.  Extensive adjustments are also performed.
   
   The version appears to be the same?  We have another PR #84 which attempts to upgrade okio.
   
   We have still not released jclouds 2.3.0 so I am considering including this PR for the upcoming release.  2.3.0 upgrades a bunch of other dependencies, including requiring Java 8, so I think bumping a few more will be OK.  What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org