You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by dhatchayani <gi...@git.apache.org> on 2017/11/15 13:13:42 UTC

[GitHub] carbondata pull request #1502: [CARBONDATA-1720] Wrong data displayed for <=...

GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/1502

    [CARBONDATA-1720] Wrong data displayed for <= filter for timestamp column(dictionary column)

    Issue:
    <= filter is giving wrong results for timestamp dictioinary column
    Solution:
    In less than equal to filter, we are considering surrogate 2 as default value. But surrogate 1 is for default value.
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [X] Testing done
            UT Added
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata lessthan_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1502.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1502
    
----
commit c8a2ba00eb2bff5a452c0417dd2a1ed768ed6023
Author: dhatchayani <dh...@gmail.com>
Date:   2017-11-15T13:11:00Z

    [CARBONDATA-1720] Wrong data displayed for <= filter for timestamp column(dictionary column)

----


---

[GitHub] carbondata issue #1502: [CARBONDATA-1720] Wrong data displayed for <= filter...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1163/



---

[GitHub] carbondata issue #1502: [CARBONDATA-1720] Wrong data displayed for <= filter...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1737/



---

[GitHub] carbondata issue #1502: [CARBONDATA-1720][FILTER] Wrong data displayed for <...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1747/



---

[GitHub] carbondata issue #1502: [CARBONDATA-1720][FILTER] Wrong data displayed for <...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1169/



---

[GitHub] carbondata issue #1502: [CARBONDATA-1720] Wrong data displayed for <= filter...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1732/



---

[GitHub] carbondata issue #1502: [CARBONDATA-1720] Wrong data displayed for <= filter...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1165/



---

[GitHub] carbondata issue #1502: [CARBONDATA-1720] Wrong data displayed for <= filter...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1738/



---

[GitHub] carbondata issue #1502: [CARBONDATA-1720][FILTER] Wrong data displayed for <...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    LGTM


---

[GitHub] carbondata issue #1502: [CARBONDATA-1720] Wrong data displayed for <= filter...

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    retest this please


---

[GitHub] carbondata issue #1502: [CARBONDATA-1720] Wrong data displayed for <= filter...

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    retest this please


---

[GitHub] carbondata issue #1502: [CARBONDATA-1720] Wrong data displayed for <= filter...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    retest sdv please


---

[GitHub] carbondata issue #1502: [CARBONDATA-1720] Wrong data displayed for <= filter...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1153/



---

[GitHub] carbondata pull request #1502: [CARBONDATA-1720][FILTER] Wrong data displaye...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1502


---

[GitHub] carbondata issue #1502: [CARBONDATA-1720] Wrong data displayed for <= filter...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1502
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1161/



---