You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/10/03 09:44:59 UTC
Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/
-----------------------------------------------------------
Review request for cloudstack and Harikrishna Patnala.
Bugs: CLOUDSTACK-2243
Repository: cloudstack-git
Description
-------
Added new test class to test Base Image Updation Facility.
Diffs
-----
test/integration/component/test_base_image_updation.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 99882fd
Diff: https://reviews.apache.org/r/14459/diff/
Testing
-------
Thanks,
Ashutosh Kelkar
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27066
-----------------------------------------------------------
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment52693>
Where is timeout declared and initialized?
- Santhosh Edukulla
On Oct. 10, 2013, 10:23 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2013, 10:23 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 0d52224
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27067
-----------------------------------------------------------
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment52694>
empty list check
- Santhosh Edukulla
On Oct. 10, 2013, 10:23 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2013, 10:23 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 0d52224
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Oct. 28, 2013, 7:02 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_base_image_updation.py, line 375
> > <https://reviews.apache.org/r/14459/diff/3/?file=369778#file369778line375>
> >
> > Whats the use of this check? We are proceeding anyways even if its not a list.
We are skipping the test if we don't get the host list
> On Oct. 28, 2013, 7:02 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_base_image_updation.py, line 577
> > <https://reviews.apache.org/r/14459/diff/3/?file=369778#file369778line577>
> >
> > Again, sleeping for 60 seconds, but decreasing timeout only by one second.
Timeout is the number of times we are allowing the loop to execute. When timeout is exhausted, we break out of the loop and test case fails raising exception
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27597
-----------------------------------------------------------
On Oct. 30, 2013, 4:56 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 4:56 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/codes.py 3da90d6
> tools/marvin/marvin/integration/lib/base.py 4f15137
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27597
-----------------------------------------------------------
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53627>
Please add more detailed doc strings or comments about this feature. This will help to understand the test feature more.
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53628>
Not clear as what we are trying to achieve. There is a timeout, we slept for five seconds, then reducing the timeout by one second? How is the variable list_template_response accessible outside of while scope? Can we please initialize it?
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53629>
Combine these two checks of list existence and length in to one. Currently we are having multiple lines, instead we can combine in to one single call, we have added a simple utility function for this check, please use that. Its under lib/commons.py
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53630>
Add an empty return here.
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53619>
what if vms is None and vms is empty list
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53620>
If vms is empty list, it will lead to exception and a script failure.
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53622>
Whats the use of this check? We are proceeding anyways even if its not a list.
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53621>
If hosts is empty list and we dont verify then that exception will be a script issue. If the list is empty , dont we see it as a bug? Ideally, we are verify the list type but not the list length. Also, why we are proceeding if its not a list. Is that true or required?
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53631>
Whats the purpose of this message, where are we waiting?
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53632>
Where is the return statement?
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53624>
Empty list check.
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53623>
Why do we need none check again when list check is already done.
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53634>
Add "RECURRING" work to codes.py. We have added this under marvin.
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53635>
We dont need an assertion here?
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53633>
Again, sleeping for 60 seconds, but decreasing timeout only by one second.
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53626>
We verified the check inside the while loop, why do we need to check again here. Also, the scope of snapshots variable is inside the while loop, how we are getting the scope of that variable here outside of while loop
- Santhosh Edukulla
On Oct. 28, 2013, 6:02 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 6:02 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 4f15137
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27595
-----------------------------------------------------------
Ship it!
Ship It!
- Girish Shilamkar
On Oct. 28, 2013, 6:02 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 6:02 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 4f15137
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Oct. 30, 2013, 1:59 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_base_image_updation.py, line 411
> > <https://reviews.apache.org/r/14459/diff/4/?file=373887#file373887line411>
> >
> > I mean why not we assert at 407? Does self.fail is same as test case failure or product bug or is it different?
Agree. I have now put an assert at 407.
> On Oct. 30, 2013, 1:59 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_base_image_updation.py, line 602
> > <https://reviews.apache.org/r/14459/diff/4/?file=373887#file373887line602>
> >
> > but where we are failing the test case here? I mean its better to fail the test case instead of raising exception. What does it is of significance when exception is raised? what is the outcome of raising exception? Will the test case be falling in fail\error state?
Changed it to self.fail. The test case should fail in this case if we don't get the list of snapshots.
Going forward Exception should signify test script issues, in this case test case result states error. While self.fail signifies a product bug/ setup issue or other CS issue, we can't really say what it is, but this results in failure and not error state.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27772
-----------------------------------------------------------
On Oct. 30, 2013, 4:56 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 4:56 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/codes.py 3da90d6
> tools/marvin/marvin/integration/lib/base.py 4f15137
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27772
-----------------------------------------------------------
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53969>
I mean why not we assert at 407? Does self.fail is same as test case failure or product bug or is it different?
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53968>
but where we are failing the test case here? I mean its better to fail the test case instead of raising exception. What does it is of significance when exception is raised? what is the outcome of raising exception? Will the test case be falling in fail\error state?
- Santhosh Edukulla
On Oct. 30, 2013, 4:56 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 4:56 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/codes.py 3da90d6
> tools/marvin/marvin/integration/lib/base.py 4f15137
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27882
-----------------------------------------------------------
Commit e47dfb673cc71a0014fc320a0a14cb8942145e8f in branch refs/heads/4.2 from Ashutosh Kelkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e47dfb6 ]
CLOUDSTACK-2243: Add automation tests for VMs base image update faclity
Signed-off-by: Girish Shilamkar <gi...@clogeny.com>
- ASF Subversion and Git Services
On Oct. 31, 2013, 6:39 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 6:39 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/codes.py 3da90d6
> tools/marvin/marvin/integration/lib/base.py 4f15137
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27881
-----------------------------------------------------------
Commit c53d4e9e141d5048a4ed2ea040fbef545c7ae9d1 in branch refs/heads/master from Ashutosh Kelkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c53d4e9 ]
CLOUDSTACK-2243: Add automation tests for VMs base image
update faclity
Signed-off-by: Girish Shilamkar <gi...@clogeny.com>
- ASF Subversion and Git Services
On Oct. 31, 2013, 6:39 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 6:39 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/codes.py 3da90d6
> tools/marvin/marvin/integration/lib/base.py 4f15137
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27880
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Oct. 31, 2013, 6:39 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 6:39 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/codes.py 3da90d6
> tools/marvin/marvin/integration/lib/base.py 4f15137
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/
-----------------------------------------------------------
(Updated Oct. 31, 2013, 6:39 a.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Review Changes
Bugs: CLOUDSTACK-2243
https://issues.apache.org/jira/browse/CLOUDSTACK-2243
Repository: cloudstack-git
Description
-------
Added new test class to test Base Image Updation Facility.
Diffs (updated)
-----
test/integration/component/test_base_image_updation.py PRE-CREATION
tools/marvin/marvin/codes.py 3da90d6
tools/marvin/marvin/integration/lib/base.py 4f15137
Diff: https://reviews.apache.org/r/14459/diff/
Testing
-------
Tested locally on KVM advanced setup:
Log:
==> result.log <==
test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
Test deploy an instance with service offerings with IsVolatile set. ... ok
test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
Test rebooting instances created with isVolatile service offerings ...
==> client.log <==
2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
th isVolatile=True
2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
th isVolatile=False
==> result.log <==
ok
test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
Test restoring a vm with different template than the one it was created with ...
==> client.log <==
2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
le=True
2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
le=False
2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
disk on vm created with IsVolatile=True
2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
inute : 53
2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
snapshoted
==> result.log <==
ok
test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
==> client.log <==
2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
atile=True was destroyed
2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
isVolatile=True was destroyed
==> result.log <==
ok
----------------------------------------------------------------------
Ran 4 tests in 3534.241s
OK
Thanks,
Ashutosh Kelkar
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Oct. 30, 2013, 6:53 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_base_image_updation.py, line 411
> > <https://reviews.apache.org/r/14459/diff/4/?file=373887#file373887line411>
> >
> > Shall we continue even if line at 407 says its not a list? Shall we exit in that case?
> > Is it a bug with product?
We can't proceed if we don't get the host list. Test case should fail in this case. We can't say if it's a product bug, there might be issue with the setup.
> On Oct. 30, 2013, 6:53 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_base_image_updation.py, line 602
> > <https://reviews.apache.org/r/14459/diff/4/?file=373887#file373887line602>
> >
> > Can we please convert it to assert instead of exception? Even if exception happens, what to do with exception, here if we are sure that Snapshot call is clean, then it has to be a product bug?
Instead of exception, will fail the test case in this case as we haven't got the snapshots list even after retry counts are exhausted.
> On Oct. 30, 2013, 6:53 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_base_image_updation.py, line 261
> > <https://reviews.apache.org/r/14459/diff/4/?file=373887#file373887line261>
> >
> > Why cant it be a product failure? What to do with this exception?
Will fail the test case in this case instead of raising exception.
> On Oct. 30, 2013, 6:53 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_base_image_updation.py, line 272
> > <https://reviews.apache.org/r/14459/diff/4/?file=373887#file373887line272>
> >
> > Added to comment at 259, i believe this statement is wrong here.
We will have to check if the return value of validateList function is PASS or FAIL. We don't have any assert in validateList function in utils.
Call to validateList along with the below assert should be moved inside while loop I believe, replacing the existing assert inside the loop.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27756
-----------------------------------------------------------
On Oct. 30, 2013, 4:56 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 4:56 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/codes.py 3da90d6
> tools/marvin/marvin/integration/lib/base.py 4f15137
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/#review27756
-----------------------------------------------------------
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53934>
Timeout it seems is not really a time out, may be better would be to rename it to retriesCnt etc. Currently, it appears to be timeout in some units say seconds
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53925>
Why this check again? We are doing some validation at 270 already i believe.
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53930>
Why cant it be a product failure? What to do with this exception?
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53933>
Added to comment at 259, i believe this statement is wrong here.
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53929>
Shall we continue even if line at 407 says its not a list? Shall we exit in that case?
Is it a bug with product?
test/integration/component/test_base_image_updation.py
<https://reviews.apache.org/r/14459/#comment53935>
Can we please convert it to assert instead of exception? Even if exception happens, what to do with exception, here if we are sure that Snapshot call is clean, then it has to be a product bug?
- Santhosh Edukulla
On Oct. 30, 2013, 4:56 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14459/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 4:56 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2243
> https://issues.apache.org/jira/browse/CLOUDSTACK-2243
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added new test class to test Base Image Updation Facility.
>
>
> Diffs
> -----
>
> test/integration/component/test_base_image_updation.py PRE-CREATION
> tools/marvin/marvin/codes.py 3da90d6
> tools/marvin/marvin/integration/lib/base.py 4f15137
>
> Diff: https://reviews.apache.org/r/14459/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM advanced setup:
>
> Log:
>
> ==> result.log <==
> test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test deploy an instance with service offerings with IsVolatile set. ... ok
> test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
> Test rebooting instances created with isVolatile service offerings ...
> ==> client.log <==
> 2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=True
> 2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
> th isVolatile=False
>
> ==> result.log <==
> ok
> test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
> Test restoring a vm with different template than the one it was created with ...
> ==> client.log <==
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
> ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
> : 5a9190a9-8a59-487f-b90f-4a76a0f509a0
> 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=True
> 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
> le=False
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
> disk on vm created with IsVolatile=True
> 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
> inute : 53
> 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
> snapshoted
>
> ==> result.log <==
> ok
> test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
> atile=True was destroyed
> 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
> isVolatile=True was destroyed
>
> ==> result.log <==
> ok
>
> ----------------------------------------------------------------------
> Ran 4 tests in 3534.241s
>
> OK
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/
-----------------------------------------------------------
(Updated Oct. 30, 2013, 4:56 a.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Review Changes
Bugs: CLOUDSTACK-2243
https://issues.apache.org/jira/browse/CLOUDSTACK-2243
Repository: cloudstack-git
Description
-------
Added new test class to test Base Image Updation Facility.
Diffs (updated)
-----
test/integration/component/test_base_image_updation.py PRE-CREATION
tools/marvin/marvin/codes.py 3da90d6
tools/marvin/marvin/integration/lib/base.py 4f15137
Diff: https://reviews.apache.org/r/14459/diff/
Testing
-------
Tested locally on KVM advanced setup:
Log:
==> result.log <==
test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
Test deploy an instance with service offerings with IsVolatile set. ... ok
test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
Test rebooting instances created with isVolatile service offerings ...
==> client.log <==
2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
th isVolatile=True
2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
th isVolatile=False
==> result.log <==
ok
test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
Test restoring a vm with different template than the one it was created with ...
==> client.log <==
2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
le=True
2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
le=False
2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
disk on vm created with IsVolatile=True
2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
inute : 53
2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
snapshoted
==> result.log <==
ok
test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
==> client.log <==
2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
atile=True was destroyed
2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
isVolatile=True was destroyed
==> result.log <==
ok
----------------------------------------------------------------------
Ran 4 tests in 3534.241s
OK
Thanks,
Ashutosh Kelkar
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/
-----------------------------------------------------------
(Updated Oct. 28, 2013, 6:02 a.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Updated patch as per review.
Bugs: CLOUDSTACK-2243
https://issues.apache.org/jira/browse/CLOUDSTACK-2243
Repository: cloudstack-git
Description
-------
Added new test class to test Base Image Updation Facility.
Diffs
-----
test/integration/component/test_base_image_updation.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 4f15137
Diff: https://reviews.apache.org/r/14459/diff/
Testing
-------
Tested locally on KVM advanced setup:
Log:
==> result.log <==
test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
Test deploy an instance with service offerings with IsVolatile set. ... ok
test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
Test rebooting instances created with isVolatile service offerings ...
==> client.log <==
2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
th isVolatile=True
2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
th isVolatile=False
==> result.log <==
ok
test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
Test restoring a vm with different template than the one it was created with ...
==> client.log <==
2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
le=True
2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
le=False
2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
disk on vm created with IsVolatile=True
2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
inute : 53
2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
snapshoted
==> result.log <==
ok
test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
==> client.log <==
2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
atile=True was destroyed
2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
isVolatile=True was destroyed
==> result.log <==
ok
----------------------------------------------------------------------
Ran 4 tests in 3534.241s
OK
Thanks,
Ashutosh Kelkar
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/
-----------------------------------------------------------
(Updated Oct. 23, 2013, 1:33 p.m.)
Review request for cloudstack and Girish Shilamkar.
Changes
-------
Review Changes
Bugs: CLOUDSTACK-2243
https://issues.apache.org/jira/browse/CLOUDSTACK-2243
Repository: cloudstack-git
Description
-------
Added new test class to test Base Image Updation Facility.
Diffs (updated)
-----
test/integration/component/test_base_image_updation.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 4f15137
Diff: https://reviews.apache.org/r/14459/diff/
Testing
-------
Tested locally on KVM advanced setup:
Log:
==> result.log <==
test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
Test deploy an instance with service offerings with IsVolatile set. ... ok
test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
Test rebooting instances created with isVolatile service offerings ...
==> client.log <==
2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
th isVolatile=True
2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
th isVolatile=False
==> result.log <==
ok
test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
Test restoring a vm with different template than the one it was created with ...
==> client.log <==
2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
le=True
2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
le=False
2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
disk on vm created with IsVolatile=True
2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
inute : 53
2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
snapshoted
==> result.log <==
ok
test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
==> client.log <==
2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
atile=True was destroyed
2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
isVolatile=True was destroyed
==> result.log <==
ok
----------------------------------------------------------------------
Ran 4 tests in 3534.241s
OK
Thanks,
Ashutosh Kelkar
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/
-----------------------------------------------------------
(Updated Oct. 10, 2013, 10:23 a.m.)
Review request for cloudstack and Girish Shilamkar.
Changes
-------
Changed local template URL. Provided Generic URL on Internet instead so that test case works in all environments.
Bugs: CLOUDSTACK-2243
Repository: cloudstack-git
Description
-------
Added new test class to test Base Image Updation Facility.
Diffs (updated)
-----
test/integration/component/test_base_image_updation.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 0d52224
Diff: https://reviews.apache.org/r/14459/diff/
Testing (updated)
-------
Tested locally on KVM advanced setup:
Log:
==> result.log <==
test_01_deploy_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
Test deploy an instance with service offerings with IsVolatile set. ... ok
test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate)
Test rebooting instances created with isVolatile service offerings ...
==> client.log <==
2013-10-09 20:22:30,659 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
th isVolatile=True
2013-10-09 20:22:30,695 - DEBUG - test_02_reboot_instance_with_is_volatile_offering (test_base_image_updation.TestBaseImageUpdate) - Checking root
th isVolatile=False
==> result.log <==
ok
test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate)
Test restoring a vm with different template than the one it was created with ...
==> client.log <==
2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo
ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem
: 5a9190a9-8a59-487f-b90f-4a76a0f509a0
2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
le=True
2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM
le=False
2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot po
disk on vm created with IsVolatile=True
2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : HOURL
inute : 53
2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till t
snapshoted
==> result.log <==
ok
test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) ...
==> client.log <==
2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of
atile=True was destroyed
2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot rule
isVolatile=True was destroyed
==> result.log <==
ok
----------------------------------------------------------------------
Ran 4 tests in 3534.241s
OK
Thanks,
Ashutosh Kelkar
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base
image update faclity
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14459/
-----------------------------------------------------------
(Updated Oct. 8, 2013, 3:58 a.m.)
Review request for cloudstack and Girish Shilamkar.
Changes
-------
Adding Girish as reviewer.
Bugs: CLOUDSTACK-2243
Repository: cloudstack-git
Description
-------
Added new test class to test Base Image Updation Facility.
Diffs
-----
test/integration/component/test_base_image_updation.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 99882fd
Diff: https://reviews.apache.org/r/14459/diff/
Testing
-------
Thanks,
Ashutosh Kelkar