You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Craig Condit (Jira)" <ji...@apache.org> on 2024/01/26 22:30:00 UTC

[jira] [Updated] (YUNIKORN-2366) Update GetPodResources() to handle in-place pod resource updates

     [ https://issues.apache.org/jira/browse/YUNIKORN-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Condit updated YUNIKORN-2366:
-----------------------------------
    Summary: Update GetPodResources() to handle in-place pod resource updates  (was: Update GetPodResources() to properly handle in-place pod resource updates)

> Update GetPodResources() to handle in-place pod resource updates
> ----------------------------------------------------------------
>
>                 Key: YUNIKORN-2366
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2366
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: shim - kubernetes
>            Reporter: Craig Condit
>            Assignee: Craig Condit
>            Priority: Major
>              Labels: pull-request-available
>
> The *GetPodResources()* function in the shim is used to convert a Pod's requested resources to a list of si.Resource objects. However, this is no longer sufficient once the *InPlacePodVerticalScaling* feature flag is enabled (or it becomes default in a future Kubernetes release).
> This function needs to also take into account the allocated resources in the {{Pod.Status.ContainerStatuses[].AllocatedResources}} collection in combination with {{Pod.Status.Resize}} to determine what the real resource utilization is. According to the [spec|https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/1287-in-place-update-pod-resources/README.md], {{AllocatedResources}} should be used instead of {{Pod.Spec.Containers[].Resources.Requests}} unless it is not present. A special case also exists where Pod.Status.Resize is set to {{InProgress}} – in this case the larger of each resource should be used to avoid over-allocating resources on a node.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org