You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/11/02 08:32:15 UTC
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2293: [type:refactor] optimize dubbo ReferenceConfig destroy
codecov-commenter edited a comment on pull request #2293:
URL: https://github.com/apache/incubator-shenyu/pull/2293#issuecomment-957207356
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2293](https://codecov.io/gh/apache/incubator-shenyu/pull/2293?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3095667) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/cb3f2294490db3e76766796a0bfe8eb107157918?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb3f229) will **decrease** coverage by `0.64%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2293 +/- ##
============================================
- Coverage 58.43% 57.78% -0.65%
+ Complexity 3972 3937 -35
============================================
Files 626 626
Lines 18056 18044 -12
Branches 1711 1710 -1
============================================
- Hits 10551 10427 -124
- Misses 6644 6770 +126
+ Partials 861 847 -14
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/alibaba/dubbo/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hbGliYWJhL2R1YmJvL2NhY2hlL0FwcGxpY2F0aW9uQ29uZmlnQ2FjaGUuamF2YQ==) | `43.75% <100.00%> (-1.35%)` | :arrow_down: |
| [...gin/apache/dubbo/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2FwYWNoZS9kdWJiby9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `45.83% <100.00%> (-1.23%)` | :arrow_down: |
| [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rg/apache/shenyu/admin/utils/ThreadLocalUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlscy5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `64.70% <0.00%> (-29.42%)` | :arrow_down: |
| [...rvice/converter/DivideSelectorHandleConverter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9jb252ZXJ0ZXIvRGl2aWRlU2VsZWN0b3JIYW5kbGVDb252ZXJ0ZXIuamF2YQ==) | `28.57% <0.00%> (-28.58%)` | :arrow_down: |
| [...rvice/converter/SelectorHandleConverterFactor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9jb252ZXJ0ZXIvU2VsZWN0b3JIYW5kbGVDb252ZXJ0ZXJGYWN0b3IuamF2YQ==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...apache/shenyu/admin/utils/CommonUpstreamUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvQ29tbW9uVXBzdHJlYW1VdGlscy5qYXZh) | `0.00% <0.00%> (-14.29%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [...in/response/strategy/NettyClientMessageWriter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc3BvbnNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3Jlc3BvbnNlL3N0cmF0ZWd5L05ldHR5Q2xpZW50TWVzc2FnZVdyaXRlci5qYXZh) | `69.56% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2293/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2293?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2293?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb3f229...3095667](https://codecov.io/gh/apache/incubator-shenyu/pull/2293?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org