[GitHub] [storm] RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

[GitBox <gi...@apache.org>]

RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r386442504
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
 ##########
 @@ -248,8 +252,17 @@ private void scheduleTopology(TopologyDetails td, Cluster cluster, final User to
     }
 
     @VisibleForTesting
-    public Set<String> getEvictedTopologies() {
-        return this.evictedTopologies;
+    public Set<String> getEvictedTopologies() throws Exception {
+        if (forTest) {
+            return this.evictedTopologies;
+        } else {
+            throw new Exception("Topology eviction check is only provided for test purposes");
 
 Review comment:
   Fixed. Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services