You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/11 00:50:38 UTC

[GitHub] [pulsar] tisonkun commented on pull request #17579: [improve][test] remove WhiteBox on MockZooKeeper

tisonkun commented on PR #17579:
URL: https://github.com/apache/pulsar/pull/17579#issuecomment-1242828452

   cc @Shoothzj @nicoloboschi 
   
   It's interesting that no test failed after remove the lines:
   
   ```java
               ObjectInstantiator<ClientCnxn> clientCnxnObjectInstantiator = objenesis.getInstantiatorOf(ClientCnxn.class);
               Whitebox.setInternalState(zk, "cnxn", clientCnxnObjectInstantiator.newInstance());
   ```
   
   I suppose that since the `MockZooKeeper` already mockup the interface, no caller will access `cnxn` field and thus it's unnecessary. However, it would be nice if the original author @eolivelli can give more background :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org