You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2026/04/10 12:10:40 UTC
[PR] Feat: Add Automatic Module Names to Maven JAR Manifests [maven]
cstamas opened a new pull request, #11921:
URL: https://github.com/apache/maven/pull/11921
Note: by doing this, Maven is not modular, as there are split packages still present.
This is more like a tinkerer PR. Idea is to create "throwaway" module names (`v3`) as with Maven 4 things will totally change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat: Add Automatic Module Names to Maven JAR Manifests [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #11921:
URL: https://github.com/apache/maven/pull/11921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat: Add Automatic Module Names to Maven JAR Manifests [maven]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #11921:
URL: https://github.com/apache/maven/pull/11921#discussion_r3065383149
##########
pom.xml:
##########
@@ -527,6 +532,21 @@ under the License.
<build>
<pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <configuration>
+ <archive>
+ <manifest>
+ <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
+ <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
+ </manifest>
Review Comment:
We have it in parent
https://github.com/apache/maven-apache-parent/blob/b4d96ca4e6fec318c8781779658b01fd2852c8cc/pom.xml#L229-L232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat: Add Automatic Module Names to Maven JAR Manifests [maven]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11921:
URL: https://github.com/apache/maven/pull/11921#issuecomment-4225643531
@cstamas Please assign appropriate label to PR according to the type of change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org