[GitHub] rhunwicks commented on issue #3302: Create a PandasDatasource

[gi...@git.apache.org]

rhunwicks commented on issue #3302: Create a PandasDatasource
URL: https://github.com/apache/incubator-superset/issues/3302#issuecomment-329067694
 
 
   @mistercrunch please can you some provide some guidance on how we would handle migrations in a contrib module, and/or lay out the directory structure.
   
   For example, if we have
   
   ````
   project_root/
       contrib/
           connectors/
               pandas
           migrations/
       superset
   ```
   
   Then we need a way to tell Superset to include those migrations when we migrate the db. We can do that by changing the value of `version_locations` in `alembic.ini` but do we need to make that change in `superset/migrations/alembic.ini`? Or do you want a separate `alembic.ini` in the `contrib/migrations` folder.
   
   A separate one keeps a loose coupling between the contrib folder and superset. But it adds more complexity to the setup and management.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services