You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/07 18:00:55 UTC
Review Request 39091: CMake:[1/3] Prepared stout tests to run with
`make check`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39091/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3597
https://issues.apache.org/jira/browse/MESOS-3597
Repository: mesos
Description
-------
Right now running the Mesos tests from the default tests target will
(1) aggregate all our tests into a semi-useless report that hides all
the errors, and (2) strip all our colors when you do pass the verbosity
flag to get rid of the "report" structure.
This commit will prepare us to run the tests with with color, without
this default reporting structure. We do this by moving the tests target
to a `CACHE STRING` which can be referenced by the tests.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 94292f8a46ec31bbaf6e52f48109322bbe123f70
Diff: https://reviews.apache.org/r/39091/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39091: CMake:[1/3] Prepared stout tests to run
with `make check`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39091/#review102604
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Oct. 13, 2015, 6:25 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39091/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 6:25 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Right now running the Mesos tests from the default tests target will
> (1) aggregate all our tests into a semi-useless report that hides all
> the errors, and (2) strip all our colors when you do pass the verbosity
> flag to get rid of the "report" structure.
>
> This commit will prepare us to run the tests with with color, without
> this default reporting structure. We do this by moving the tests target
> to a `CACHE STRING` which can be referenced by the tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 94292f8a46ec31bbaf6e52f48109322bbe123f70
>
> Diff: https://reviews.apache.org/r/39091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39091: CMake:[1/3] Prepared stout tests to run
with `make check`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39091/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 6:25 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3597
https://issues.apache.org/jira/browse/MESOS-3597
Repository: mesos
Description
-------
Right now running the Mesos tests from the default tests target will
(1) aggregate all our tests into a semi-useless report that hides all
the errors, and (2) strip all our colors when you do pass the verbosity
flag to get rid of the "report" structure.
This commit will prepare us to run the tests with with color, without
this default reporting structure. We do this by moving the tests target
to a `CACHE STRING` which can be referenced by the tests.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 94292f8a46ec31bbaf6e52f48109322bbe123f70
Diff: https://reviews.apache.org/r/39091/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39091: CMake:[1/3] Prepared stout tests to run
with `make check`.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39091/#review102404
-----------------------------------------------------------
LGTM.
- Artem Harutyunyan
On Oct. 7, 2015, 9 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39091/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 9 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Right now running the Mesos tests from the default tests target will
> (1) aggregate all our tests into a semi-useless report that hides all
> the errors, and (2) strip all our colors when you do pass the verbosity
> flag to get rid of the "report" structure.
>
> This commit will prepare us to run the tests with with color, without
> this default reporting structure. We do this by moving the tests target
> to a `CACHE STRING` which can be referenced by the tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 94292f8a46ec31bbaf6e52f48109322bbe123f70
>
> Diff: https://reviews.apache.org/r/39091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39091: CMake:[1/3] Prepared stout tests to run
with `make check`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39091/#review101792
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Oct. 7, 2015, 9 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39091/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 9 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3597
> https://issues.apache.org/jira/browse/MESOS-3597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Right now running the Mesos tests from the default tests target will
> (1) aggregate all our tests into a semi-useless report that hides all
> the errors, and (2) strip all our colors when you do pass the verbosity
> flag to get rid of the "report" structure.
>
> This commit will prepare us to run the tests with with color, without
> this default reporting structure. We do this by moving the tests target
> to a `CACHE STRING` which can be referenced by the tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 94292f8a46ec31bbaf6e52f48109322bbe123f70
>
> Diff: https://reviews.apache.org/r/39091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>